Exposed filter cannot be configured to be <Any> by default

1. Argh, I thought this had been fixed.

2. Argh, why are you using Flag? The use case is right, but Flag is ***NOT READY FOR PRODUCTION***. There are a ton of issues, including major issues around render caching and performance.

Are you sure you have the latest version?

In FlagViewsFilter:

    $form['value']['#options'] = [
      'All' => t('All'),
      1 => $this->t('Flagged'),
      0 => $this->t('Not flagged'),
    ];

Default value is set 1. Use this patch to change to 'All' value.

in/views/filter/FlagViewsFilter.php
index 9b7f2ebe..281a9aa5 100644
--- a/modules/contrib/flag/src/Plugin/views/filter/FlagViewsFilter.php
+++ b/modules/contrib/flag/src/Plugin/views/filter/FlagViewsFilter.php
@@ -17,7 +17,7 @@ class FlagViewsFilter extends BooleanOperator {
*/
public function defineOptions() {
$options = parent::defineOptions();
- $options['value'] = ['default' => 1];
+ $options['value'] = ['default' => 'All'];
$options['relationship'] = ['default' => 'flag_relationship'];

return $options;

http://prntscr.com/krjpnf

Changing status to "Needs work" because #6 provides a solution but not a formal patch that can be tested on drupal.org.

Resolved all PHPCS Issues.

Like mentioned in comment #4 this is already part of the module and works. When filter is exposed to visitors, the "required " check box needs to be removed. If the filter is not exposed to visitors, the default value is set to true. Don't think that changing it to All does anything.

The thing that this MR changes is the default value is no longer true, but All. Everything else stays the same. So not sure if this needs to be merged at all. Will rebase branch in case the desire is there to merge it.

Still needs tests

Added a test that sets the exposed filter for flagging and checked that the - Any - options is visible on the actual page. Ready for review.

@deaom I tested this patch manually. It doesn't work as expected. When I selected "All" I get flagged nodes anyway. I think needs to extend the test and check which nodes were filtered

When you select All you should get flagged and unflagged, so not quite understanding what does not work when manually testing. Will try and extend the test.

Updated the test to test that flagged and unflagged content is listed/displayed, now that Drupal is back, tests also passing. Ready for review.

I forgot to remove "status" filter like this

$this->drupalGet('/admin/structure/views/nojs/handler/flag_bookmark/page_1/filter/status');
$this->assertSession()->elementExists('css', '#edit-remove');
$this->submitForm([], 'Remove');

(facepalm)

Tested again, it works as expected