Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.At the moment, the only permission available in this module applies to all taxonomies.
Ideally, separate permissions per taxonomy were available, such as taxonomy_access_fix provides for adding terms, or alternatively the edit and/or delete permission would be checked in addition to the merge permission.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2984402-7.patch | 8.29 KB | legolasbo |
| #7 | interdiff-2984402-4-7.txt | 2.12 KB | legolasbo |
| #4 | interdiff-2984402-3-4.txt | 2.48 KB | legolasbo |
| #3 | 2984402-3-test-only.patch | 5.69 KB | legolasbo |
Comments
Comment #2
grahlI don't have time to work on a patch for this myself at the moment but maybe someone else also has an interest in this.
Comment #3
legolasboI think the approach where we combine the 'merge taxonomy terms' with the 'edit terms in *' permissions is probably the best. The merging of terms should count as editing them, because any references to them get updated in the process.
This patch adds tests for that use case and are obviously failing. I'll upload another patch with the actual implementation shortly.
Comment #4
legolasboAttached patch implements the additional access check.
Comment #5
marcoweijenborg commentedI can only see 2 small things here:
1. In src/Access/MergeAccess.php, there is too much whitespace between the <?php tag and the namespace directive.
2. The same in tests/src/Functional/TermMergeTestBase.php: too much whitespace around the namespace directive.
The rest seems ok to me :)
Comment #6
marcoweijenborg commentedComment #7
legolasboThanks for your review! Looking at this again I found some other improvements besides the ones you mentioned. See the attached patch :)
Comment #8
marcoweijenborg commentedOk looks good!
Comment #9
marcoweijenborg commentedComment #10
legolasboCommitted and pushed 8.x-1.x