Summary facet is showing ('No results found.'), regardless the option 'Hide Summary when Facet Source is not rendered' is enabled.

CommentFileSizeAuthor
#9 2978535.patch4.96 KBborisson_
#6 2978535.patch4.93 KBborisson_
#6 2978535--test-only.patch1.36 KBborisson_
#5 2978535.patch3.57 KBborisson_

Comments

andreasderijcke created an issue. See original summary.

andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
commented

After a closer look:

  1. "Hide Summary when Facet Source is not rendered": enabled, weight 10
  2. "Show a text when there are no results: enabled, weight 30

Issue is fixed when "Hide Summary when Facet Source is not rendered" is run last.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

We should add both documentation and more sane defaults to fix this.

borisson_ credited Nick_vh.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new 2978535.patch3.57 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new 2978535--test-only.patch1.36 KB
new 2978535.patch4.93 KB

I added a test to ensure that this stays like it's supposed to.

The last submitted patch, 6: 2978535--test-only.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: 2978535.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 2978535.patch4.96 KB

  • borisson_ committed 43af879 on 8.x-1.x 
    Issue #2978535 by borisson_, andreasderijcke, Nick_vh: Facet Summary: "...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.