Rename the commerce submodule are decided in the parent issue #2961979: Rename migrations and plugins

CommentFileSizeAuthor
#16 interdiff.txt590 bytesquietone
#16 2969074-16.patch144.94 KBquietone
#14 2969074-14.patch144.94 KBquietone
#14 interdiff.txt3.14 KBquietone
#12 interdiff.txt930 bytesquietone
#12 2969074-12.patch140.37 KBquietone
#9 interdiff.txt930 bytesquietone
#9 2969074-9.patch140.37 KBquietone
#7 interdiff.txt6.52 KBquietone
#7 2969074-7.patch139.46 KBquietone
#5 interdiff.txt21.15 KBquietone
#5 2969074-5.patch139.11 KBquietone
#4 interdiff.txt608 bytesquietone
#4 2969074-4.patch136.27 KBquietone
#2 2969074-2.patch136.27 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2969074-2.patch136.27 KB

First go at the changes. Changed everything except for comments.

Status: Needs review » Needs work

The last submitted patch, 2: 2969074-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2969074-4.patch136.27 KB
new interdiff.txt608 bytes

Incorrect character leftover from a sed command that I cleanup by hand and missed one.

quietone’s picture

quietone commented
StatusFileSize
new 2969074-5.patch139.11 KB
new interdiff.txt21.15 KB

Now update the comments to change references to D7 to Commerce 1 or similar.

quietone’s picture

quietone commented
Status: Needs review » Needs work 
+++ b/modules/commerce/migrations/commerce1_billing_profile.yml
@@ -1,10 +1,10 @@
   - Commerce 1

all the 'Commerce 1' tags can be changed to Commerce

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2969074-7.patch139.46 KB
new interdiff.txt6.52 KB

Change the migration tags.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Needs work

There still seems to be some occurrences of 'Commerce 1'. Back to NW.

Do we need to worry about BC? Since we are still in alpha, probably not. Sorry folks, I know this will probably hurt a little.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2969074-9.patch140.37 KB
new interdiff.txt930 bytes

Yes, I didn't do a grep on the module. Thanks for spotting it. I found 2 instances of Commerce 1 in two test files.

Yes, sorry about the change but it will help in the future.

Status: Needs review » Needs work

The last submitted patch, 9: 2969074-9.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

CommerceMigrationProvidersExistTest and 31 other files still mention 'Commerce 1'.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2969074-12.patch140.37 KB
new interdiff.txt930 bytes

Needed to start over and reroll the patch in #7. This patch does that and adds the changes made in patch #9, which changes 'Commerce 1' to 'Commerce' for the tags in two tests.

As for the other 31 files, the instance of 'Commerce 1' is in comments which are specific to Commerce 1.

Status: Needs review » Needs work

The last submitted patch, 12: 2969074-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.14 KB
new 2969074-14.patch144.94 KB

Adding fixes for the latest commits which used the old naming system.

quietone’s picture

quietone commented

With this patch grep finds 41 instances of 'Commerce 1' all in comments, which I think is OK. It makes it clear what the code is for and it can be changed as needed when Commerce 2 sources are used. Or am I missing something on this fine day?

quietone’s picture

quietone commented
StatusFileSize
new 2969074-16.patch144.94 KB
new interdiff.txt590 bytes

And let's fix the coding standard error, a removal of an unused use statement.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Fixed

  • heddn committed 5c7e172 on 8.x-2.x authored by quietone 
    Issue #2969074 by quietone, heddn: Renaming for Commerce sub module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.