MultichoiceQuestion::saveNodeProperties is checking new nodes with

    $is_new = $is_new || $this->node->revision == 1;

But it gives a warning when adding questions to quiz via configuration-screen-question-bank page. Small patch in attachment to fix this.

Tested against 5.2 version.

CommentFileSizeAuthor
#3 undefined_property_revision_on_node_in_multichoice-2962037-3.patch670 byteslorenzs
#2 undefined_property_revision_on_node_in_multichoice-2962037-2.patch640 byteslorenzs

Comments

lorenzs created an issue. See original summary.

lorenzs’s picture

lorenzs commented
StatusFileSize
new undefined_property_revision_on_node_in_multichoice-2962037-2.patch640 bytes
lorenzs’s picture

lorenzs commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new undefined_property_revision_on_node_in_multichoice-2962037-3.patch670 bytes

Updated patch because of test-failure.

lorenzs’s picture

lorenzs commented
Issue summary: View changes
Issue tags: +patch-to-be-reviewed
djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Thanks, committed but I just changed it to an empty() check.

  • djdevin committed b29ac14 on 7.x-5.x authored by lorenzs 
    Issue #2962037 by lorenzs: undefined property revision on node in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.