Problem/Motivation
This feels like a very important personal privacy issue, just because I have put my name and avatar on Drupal.org, does not mean that I would want it included/displayed via the Contribute module. I absolutely believe this process should be opt-in in order to allow each individual to make this decision for themselves, and not have you make it for them. I'm sure some people, if not most would be ok with it, but it's not worth it to for those who would absolutely say no.
Proposed resolution
Make the display of contributors opt-in
Remaining tasks
Do it.
User interface changes
Only those who opt-in will have their name and likeness included.
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2944781-12.patch | 122.89 KB | jrockowitz |
| #11 | 2944781-11.patch | 122.89 KB | jrockowitz |
Comments
Comment #2
dave reidComment #3
dave reidComment #4
dave reidComment #5
gddI agree with this. The display of these people's names and avatars gives an implicit message that they support the DA and/or the Contribute module, and this is not necessarily the case. I don't support either of these efforts and in fact, I would be kind of horrified to have that be implied. Additionally, from a personal standpoint, people just might not want their image or name spread out that widely due to their own personal privacy concerns. This functionality should be opt-in or removed.
Comment #6
adriancidHi @Dave Reid thanks for reporting, would be great if the next time you use the Issue Summary Template to report an issue.
Do you have an idea about how to request the inclusion or not in the module?
Comment #7
tim.plunkettComment #8
dave reidI don't really have any idea aside from the maintainers of Contribute would need to personally reach out to each person to get their feedback and approval. And then be able to whitelist which people are visible once they have done so.
Comment #9
adriancidHi @tim.plunkett, do you have any idea about how to request the permission? I can't see how to do this in the module, we need to open a poll about this? Imagine that each week somebody wants to show or not his information, we will need to make many releases only to support this.
Comment #10
tim.plunkettYou need to remove everyone that you have not gained explicit permission from.
It is not something you can automate without adding some checkbox to Drupal.org itself.
Comment #11
jrockowitz commented@Dave Reid Thank you for catching this mistake.
I apologize and take responsibility for this mistake. I completely understand that even though someone's user profile and picture is on Drupal.org, it does not automatically mean it should be included and distributed within a module. I failed to take into consideration how this would be perceived by others and especially the people involved.
I hope people understand how important I feel it is acknowledged everyone's contributions to Drupal core and contrib projects. We should continue to have a reasonable and ongoing conversation on Durpal.org.
The attached patch removes #2944296: Display maintainers/contributors for installed projects. Once all the test pass, I will commit it and tag a new release.
Comment #12
jrockowitz commentedComment #15
jrockowitz commented@see https://www.drupal.org/project/contribute/releases/8.x-1.0-beta7
Comment #16
dave reid@jrockowitz, thanks I really appreciate the quick action on this to respect the people I know would have been truly uncomfortable with this.
Comment #17
adriancidGiving credit ;-)