After selecting another option and saving the form always stay selected the first option. For all widgets text displayed correctly.

CommentFileSizeAuthor
#3 interdiff.txt2.9 KBid.rem.dev
#3 fix_copyright_option-2940021-3.patch4.27 KBid.rem.dev
#2 fix_copyright_option-2940021-2.patch2.24 KBlolandese
Screenshot from 2018-01-27 16-10-23.png19.07 KBknyshuk.vova

Comments

knyshuk.vova created an issue. See original summary.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new fix_copyright_option-2940021-2.patch2.24 KB

Attached patch fixes the issue. If reviewing test also on a clean new install an then going to the "fresh" settings form. It should give the first option to be the default also in that case.

id.rem.dev’s picture

id.rem.dev commented
Assigned: knyshuk.vova » Unassigned
StatusFileSize
new fix_copyright_option-2940021-3.patch4.27 KB
new interdiff.txt2.9 KB

Improvements:
- replaced directly $GLOBALS usage with "request_stack" service;
- improved if else logic;
Added interdiff.
Please, review.

lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and fixes the issue.

The proposed improvements make sense. Nice. Thanks.

  • Vladimirrem authored 20554ea on 8.x-1.x 
    Issue #2940021 by Vladimirrem, lolandese: Wrong copyright option...
knyshuk.vova’s picture

knyshuk.vova commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.