Instead of using Drupal\Core\Form\FormBase we better use Drupal\Core\Form\ConfigFormBase. As it includes some functionality we need (e.g. submit button) we can avoid some code duplication apart of being more consistent with the normal form implementation for a settings page.

CommentFileSizeAuthor
#2 better_form-2935376-2.patch4.99 KBlolandese

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new better_form-2935376-2.patch4.99 KB

The patch implements form implementation more conform for a settings page. Furthermore it has some code sniffer suggestions included.

lolandese’s picture

lolandese commented
Issue summary: View changes
knyshuk.vova’s picture

knyshuk.vova commented
Issue tags: +LutskGSW18
remnis’s picture

remnis commented

I will review the issue

remnis’s picture

remnis commented
Assigned: Unassigned » remnis
remnis’s picture

remnis commented
Assigned: remnis » Unassigned
Status: Needs review » Reviewed & tested by the community

Reviewed, the patch does not break the logic of the module and matches the Drupal code standards.

  • lolandese authored 6e4d78c on 8.x-1.x 
    Issue #2935376 by lolandese, remnis: Some form improvements
knyshuk.vova’s picture

knyshuk.vova commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.