Need to display [[ in code [#2934596]

We need to display "[[" in a <code> tag. When you add this tag first and then an image, the result is that the text doesn't appear as expected.

For example:

IMHO we can avoid this problem by detecting "[[{" instead of "[["

Basically:

define('MEDIA_WYSIWYG_TOKEN_REGEX', '/\[\[\{.+?"type":"media".+?\}\]\]/s');

instead of

define('MEDIA_WYSIWYG_TOKEN_REGEX', '/\[\[.+?"type":"media".+?\]\]/s');

Here is the result:

Thanks!

Comment	File	Size	Author
#2	Screen Shot 2018-01-05 at 9.34.57 AM.png	55.76 KB	marthinal
	double-square-brackets-media-wysiwyg.patch	578 bytes	marthinal
	Screen Shot 2018-01-05 at 9.36.44 AM.png	231.86 KB	marthinal
	Screen Shot 2018-01-05 at 9.36.11 AM.png	138.35 KB	marthinal
	Screen Shot 2018-01-05 at 9.50.26 AM.png	136.76 KB	marthinal
	Screen Shot 2018-01-05 at 9.34.34 AM.png	238.97 KB	marthinal

Comments

Comment #1

5 January 2018 at 09:05

marthinal created an issue. See original summary.

Comment #2

marthinal commented 5 January 2018 at 09:09

Issue summary:

View changes

Status	File	Size
new	Screen Shot 2018-01-05 at 9.34.57 AM.png	55.76 KB

Comment #3

joseph.olstad

French

commented 5 January 2018 at 17:13

**EDIT**
deleted comment for now

Comment #4

joseph.olstad

French

commented 5 January 2018 at 17:16

ok, looks reasonable, however this regex needs a bit of review because it is responsible for how the media embed works, before any commit this needs to be reviewed thoroughly to make sure no regressions.

Comment #5

joseph.olstad

French

commented 16 January 2018 at 23:04

I haven't yet had time to do a thorough review. Looks good though at first glance. Again, this regex is very important so want to take a closer look, hopefully soon.