The last version 8.x-2.0-alpha6 contains important bugs that make the geocoder_field submodule not working at all.
In particular bugs are coming from the following patch issues:

  • Issue #2841914 by jhedstrom: Geocoder::geocode() is looping through provider labels not the plugin_id:
    the patch code is not needed at all, as the $geocoder['plugins'] and the $plugins variables are already a list of plugins machine names, and the patch code is totally wrong, making the Geocoder Service not working at all;
    Moreover that (wrong) patch was caring just of the Geocoder->geocode method and not of the Geocoder->reverse one, that should be (in the case) affected by the same matters
  • Issue #2798179 by bartlangelaan: Implement Multi-value input handling (delta_handling):
    the patch code removed the "continue" statement from the original code in the for cycle, thus bypassing the correct preserve of any geocode result, and calling the failure message/log every time;

The attached patch corrects the above (introduced) critical bugs and makes the module working properly again.

Comments

itamair created an issue. See original summary.

itamair’s picture

Status: Active » Needs review
StatusFileSize
new2.2 KB
itamair’s picture

Issue summary: View changes
itamair’s picture

Issue summary: View changes
itamair’s picture

Issue summary: View changes
itamair’s picture

Issue summary: View changes
itamair’s picture

Issue summary: View changes

  • Pol committed 527ab98 on 8.x-2.x authored by itamair
    Issue #2931803 by itamair: Critical bugs in the last 8.x-2.0-alpha6 -...
pol’s picture

Status: Needs review » Fixed

Thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.