Geocoder::geocode() is looping through provider labels not the plugin_id

Thanks!

While following the following example:
https://github.com/drupol/geocoder/blob/8.x-2.x/README.md

I get the following error:
The "0" plugin does not exist.

The following patch was applied.
modules/gecoder/src/Geocoder.php
From

  public function geocode($data, array $plugins, array $options = []) {
    foreach ($plugins as $plugin_id) {
      $options += [$plugin_id => []];
      $provider = $this->providerPluginManager->createInstance($plugin_id, $options[$plugin_id]);

To

  public function geocode($data, array $plugins, array $options = []) {
    foreach (array_keys($plugins) as $plugin_id) {
      $options += [$plugin_id => []];
      $provider = $this->providerPluginManager->createInstance($plugin_id, $options[$plugin_id]);

The problem was resolved when I reverted the patch.


Output $options with patch:

array(4) {
  ["geonames"]=>
  array(0) {
  }
  ["googlemaps"]=>
  array(0) {
  }
  ["bingmaps"]=>
  array(0) {
  }
  [0]=>
  array(0) {
  }
}

Output $options without patch:

array(3) {
  ["geonames"]=>
  array(0) {
  }
  ["googlemaps"]=>
  array(0) {
  }
  ["bingmaps"]=>
  array(0) {
  }
}

$options being supplied to geocode:

array(3) {
  ["geonames"]=>
  array(0) {
  }
  ["googlemaps"]=>
  array(0) {
  }
  ["bingmaps"]=>
  array(0) {
  }
}

Tldr; Problem was resolved when reverting patch

Is this the final API ? Because it breaks the latest dev of search_api_location for example. Should I provide a patch for that module to match the changes applied here ?

If so, I think the documentation of the GeocoderInterface, which mentions, about $plugins, "A list of plugin identifiers to use.", should be updated.

/**
   * Geocodes a string.
   *
   * @param string $data
   *   The string to geocoded.
   * @param string[] $plugins
   *   A list of plugin identifiers to use.
   * @param array $options
   *   (optional) An associative array with plugin options, keyed plugin by the
   *   plugin id. Defaults to an empty array.
   *
   * @return \Geocoder\Model\AddressCollection|null
   *   An address collection or NULL on gecoding failure.
   */
  public function geocode($data, array $plugins, array $options = []);

I'm personally reverting to previous commit for now.

Here's a patch that applies to the latest 2.x-dev.

Thanks !

The #12 patch introduces a great regression and everything breaks.
The committed #12 patch should be reverted immediately as not needed, and indeed harmful.
To verify just enable a Geocode operation on a field with just a Plugin.
The Drupal\geocoder\Geocoder geocode function will fail, as the $plugins already is an array of plugins machine names,
and array_keys($plugins) will return a list of not existing plugins.
So ... IMO we should really immediately revert the just committed #12 patch ...

Once the committed #12 patch has been reverted this issue might be closed anyway, because this sounds to me as an old-outdated issue.
(fixed by the last beta versions of the module)

reverted the previously committed #12 patch.
Closing this one ...