Problem/Motivation
Masquerade module needs to be converted to use short array syntax as per new coding standard.

Proposed resolution
Convert all array() codes into [] as per the coding standard.

https://www.drupal.org/docs/develop/standards/coding-standards#array

Remaining tasks
Nil

User interface changes
Nil

API changes
Nil

Data model changes
Nil

Thanks advance,
Arunkumar K

CommentFileSizeAuthor
#9 2930942-9.patch6.3 KBandypost
#8 PareviewLog.png1.02 MBAanal.addweb
#5 2930942-5.patch9.4 KBandypost
#5 2930942-interdiff-2.txt4.69 KBandypost
#2 short-array-2930942-2.patch5.28 KBarunkumark

Comments

arunkumark created an issue. See original summary.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Active » Needs review
StatusFileSize
new short-array-2930942-2.patch5.28 KB

I have created a patch to resolve the Shorthand array coding standard issue fix.

Status: Needs review » Needs work

The last submitted patch, 2: short-array-2930942-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Needs work » Needs review

The branch is not set properly, that is the reason patch get fails. Keeping that needs review.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 2930942-interdiff-2.txt4.69 KB
new 2930942-5.patch9.4 KB

Here's a patch with remaining fixes

btw Work on fixing tests happens in #2923960: Convert Simpletest tests to BrowserTestBase

Status: Needs review » Needs work

The last submitted patch, 5: 2930942-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

test fail now

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new PareviewLog.png1.02 MB

@andypost, Thanks for patch, but in my case your patch works well as per the errors are shown in pareview.sh.
All the short array index errors are now resolved. PFA of my pareview verification.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 2930942-9.patch6.3 KB

Final patch to commit after #2448707: Fix masquerade tests

andypost’s picture

andypost
he/him
Primary language Russian
commented

Some error require further refactoring and should go to separate issue

  • andypost committed 08d47ba on 8.x-2.x 
    Issue #2930942 by andypost, arunkumark, dhwani.addweb: Convert module...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

https://pareview.sh/pareview/https-git.drupal.org-project-masquerade.git...

  • andypost committed 37bf1d8 on 8.x-2.x 
    Issue #2930942 by andypost: Follow-up to fix coding standard

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.