Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
For now, the Unit tests totally broken (tested with Drupal v8.4.2 on localhost).
I am proposing to fix and move to masquerade/tests/src/Functional.
Going to provide the patch.
Thank you.
Comment | File | Size | Author |
---|---|---|---|
#17 | 2923960-17.patch | 16.42 KB | andypost |
#17 | 2923960-interdiff-15.txt | 1.52 KB | andypost |
Comments
Comment #2
Ruslan PiskarovThe patch for review.
Comment #3
Ruslan PiskarovFrankly speaking, the current tests (in master I mean) totally broken, so they will fail in any case, because broken test can't make tests for new tests )))
Comment #4
andypostPatch queued to test, thanx a lot for conversion, I missed that tests were not converted yet
Comment #5
andypostproper title
Comment #7
Ruslan PiskarovHm, something still was broken. I will investigate soon. Thank you.
Comment #8
Ruslan PiskarovI apologize for the delay. Very stuck in the work. I do not know when I'll find the time to fix one test, in which there is a problem with the sessions.
Comment #9
andypostHere's a clean-up of useless changes, actually I'd prefer to split patches for tests conversion & clean-up
Comment #11
andypostThe session failure goes from
\Drupal\Tests\masquerade\Functional\MasqueradeWebTestBase::assertSessionByUid()
which starting session but it's not in testing browserThe hack breaks execution and tests now should pass
Comment #13
andypostRework of method to use string comparison instead of hacking decode session.
Comment #15
andypostanother round, somehow locally tests pass
Comment #17
andypostComment #19
andypostThe only thing I can imagine is that testbot using to run tests in subdir but that tells nothing why response code 500
Comment #20
Ruslan PiskarovHello @andypost.
I will try to find time too and have a look at this. Thank you for your work.
Comment #21
andypostFinally tests are fixed in #2951196: Permission Denied when trying to masquerade when site in subdir
It may have collision with #2930942: Convert module Masquerade to use short array syntax (new coding standard).
Comment #22
andypostGetting in
Comment #24
andypost