Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ruslan P created an issue. See original summary.

Ruslan Piskarov’s picture

Status: Active » Needs review
FileSize
14.88 KB

The patch for review.

Ruslan Piskarov’s picture

Frankly speaking, the current tests (in master I mean) totally broken, so they will fail in any case, because broken test can't make tests for new tests )))

andypost’s picture

Patch queued to test, thanx a lot for conversion, I missed that tests were not converted yet

andypost’s picture

Title: To fix Unit tests » Convert Simpletest tests to BrowserTestBase

proper title

Status: Needs review » Needs work

The last submitted patch, 2: masquerade-to-fix-unit-tests-2923960-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Ruslan Piskarov’s picture

Hm, something still was broken. I will investigate soon. Thank you.

Ruslan Piskarov’s picture

I apologize for the delay. Very stuck in the work. I do not know when I'll find the time to fix one test, in which there is a problem with the sessions.

andypost’s picture

Status: Needs work » Needs review
FileSize
2.39 KB
12.84 KB

Here's a clean-up of useless changes, actually I'd prefer to split patches for tests conversion & clean-up

Status: Needs review » Needs work

The last submitted patch, 9: 2923960-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andypost’s picture

Status: Needs work » Needs review
FileSize
2.73 KB
12.99 KB
12.84 KB

The session failure goes from \Drupal\Tests\masquerade\Functional\MasqueradeWebTestBase::assertSessionByUid() which starting session but it's not in testing browser

The hack breaks execution and tests now should pass

Status: Needs review » Needs work

The last submitted patch, 11: 2923960-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andypost’s picture

Status: Needs work » Needs review
FileSize
9.12 KB
14.9 KB

Rework of method to use string comparison instead of hacking decode session.

Status: Needs review » Needs work

The last submitted patch, 13: 2923960-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andypost’s picture

Status: Needs work » Needs review
FileSize
1.85 KB
16.08 KB

another round, somehow locally tests pass

Status: Needs review » Needs work

The last submitted patch, 15: 2923960-15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andypost’s picture

Status: Needs review » Needs work

The last submitted patch, 17: 2923960-17.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

andypost’s picture

The only thing I can imagine is that testbot using to run tests in subdir but that tells nothing why response code 500

Ruslan Piskarov’s picture

Hello @andypost.
I will try to find time too and have a look at this. Thank you for your work.

andypost’s picture

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Getting in

  • andypost committed 423cf2b on 8.x-2.x
    Issue #2923960 by andypost, RuslanP: Convert Simpletest tests to...
andypost’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.