Entity queries broken for non-DER entity reference base fields

This demonstrates the issue. If the same test is run w/o DER enabled, this passes.

  /**
   * {@inheritdoc}
   */
  protected function addNextBaseTable(EntityType $entity_type, $table, $sql_column) {
    // Parent method is overridden in order to choose the correct column to
    // join on (string or int).
    $entity_type_id_key = $entity_type->getKey('id');
    if ($entity_type_id_key !== FALSE) {
      if (DynamicEntityReferenceItem::entityHasIntegerId($entity_type->id())) {
        $sql_column .= '_int';
      }
    }
    return parent::addNextBaseTable($entity_type, $table, $sql_column);
  }

This logic is appending _int for any entity reference field. Not sure how to fix as this is sitting bellow the field API level where we'd know whether this was a DER field or not...

Here's a demonstration of how we could resolve this with the attached patch for core. Not sure how readily we could get that in, so posting here for thoughts. This will fail on the test bots since they won't apply the core patch :)

Interestingly enough, this works in core 8.2.x. I'm currently running git bisect to figure out what changed.

I'll open up a core issue shortly.

Ah, this is what changed between 8.2 and 8.4/8.5: #2424791: Entity query hardcodes entity_reference and entity specifier.

I've opened #2908605: Pass field storage to Tables::addNextBaseField().

Ah, that's why it "works" in 8.2.x--the addNextBaseTable method didn't exist then, so the override we have here was never triggered.

Is it also broken for entity reference configurable fields?

It appears to be. I've added a normal entity reference configurable field test here. It fails in the same manner, and passes with the proposed core fix.

I made the entire conditional dependent on the field storage, since otherwise, this error will still be present on sites that somehow this method gets called for that aren't up-to-date and passing in the field storage...

This fixes some issues with the tests.

This should do it I think :)