Problem/Motivation

Update \Drupal\Core\Entity\Query\Sql\Tables::addNextBaseTable signature to accomdate the additional $field_storage parameter.

Proposed resolution

Update \Drupal\Core\Entity\Query\Sql\Tables::addNextBaseTable signature to accomdate the additional $field_storage parameter.

The change has been approved in #2908605-17: Pass field storage to Tables::addNextBaseField()

There's two things the followup issue could be. Since this is a protected method not on a corresponding interface, our BC policy allows us to change it in a minor release if we want. The full BC thing to do would be to deprecate the method and add a new one with the new signature. However, that seems unnecessary to me; just wanted to document that I'd thought it through.

Remaining tasks

Postpone on #2908605: Pass field storage to Tables::addNextBaseField().

User interface changes

None

API changes

\Drupal\Core\Entity\Query\Sql\Tables::addNextBaseTable signature is updated to accomdate the additional $field_storage parameter.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

xjm’s picture

Status: Postponed » Active

The parent is in.

jibran’s picture

Status: Active » Needs review
FileSize
2.49 KB

Here we go.

jhedstrom’s picture

Status: Needs review » Reviewed & tested by the community

Looks good!

  • larowlan committed 63a95d5 on 8.5.x
    Issue #2909425 by jibran: Add the $field_storage parameter to Tables::...

larowlan credited larowlan.

larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Committed as 63a95d5 and pushed to 8.5.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.