Problem/Motivation
Update \Drupal\Core\Entity\Query\Sql\Tables::addNextBaseTable
signature to accomdate the additional $field_storage parameter.
Proposed resolution
Update \Drupal\Core\Entity\Query\Sql\Tables::addNextBaseTable
signature to accomdate the additional $field_storage parameter.
The change has been approved in #2908605-17: Pass field storage to Tables::addNextBaseField()
There's two things the followup issue could be. Since this is a protected method not on a corresponding interface, our BC policy allows us to change it in a minor release if we want. The full BC thing to do would be to deprecate the method and add a new one with the new signature. However, that seems unnecessary to me; just wanted to document that I'd thought it through.
Remaining tasks
Postpone on #2908605: Pass field storage to Tables::addNextBaseField().
User interface changes
None
API changes
\Drupal\Core\Entity\Query\Sql\Tables::addNextBaseTable
signature is updated to accomdate the additional $field_storage parameter.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#3 | add_the_field_storage-2909425-3.patch | 2.49 KB | jibran |
Comments
Comment #2
xjmThe parent is in.
Comment #3
jibranHere we go.
Comment #4
jhedstromLooks good!
Comment #7
larowlanCommitted as 63a95d5 and pushed to 8.5.x.