The current version of implements hook_entity_create_access to allow users to create specific types of block content. However the route to the block content creation form still requires the “administer blocks” permission. Adding this permission seems to go against the entire purpose of this module as it will grant access to all block content types anyhow.

CommentFileSizeAuthor
#6 2907558-pass.patch4.27 KBlarowlan
#6 2907558-fail.patch1.24 KBlarowlan
#2 create-block-form-access-2907558-2.patch4.3 KBkasperg

Comments

kasperg created an issue. See original summary.

kasperg’s picture

kasperg commented
Status: Active » Needs work
StatusFileSize
new create-block-form-access-2907558-2.patch4.3 KB

Here is an attempt at fixing this by changing the access control for the block content create form route to allow either “administer blocks” or the new per block content type permissions.

It still needs a test. Perhaps someone wants to pick up that gauntlet.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Need tests
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

+1 to this if we add tests

alfattal’s picture

alfattal commented

@kasperg I've applied the patch in #2 and it doesn't seems to work. I still need to add "Administer Blocks" for blocks creation.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
Issue tags: -Need tests
StatusFileSize
new 2907558-fail.patch1.24 KB
new 2907558-pass.patch4.27 KB

The last submitted patch, 6: 2907558-fail.patch, failed testing. View results

  • larowlan committed 37b75b1 on 8.x-1.x 
    Issue #2907558 by larowlan, kasperg: Do not require administer blocks...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

Cutting a 1.0 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.