Regression introduced in this issue: https://www.drupal.org/node/2243413

Original issue: https://www.drupal.org/node/1125582

Bug fix: Basically checks for if the tinymce fullscreen mode is active and prepares the content appropriately while leaving the AJAX fix as is.

CommentFileSizeAuthor
#8 TinyMCE 4.5.7 Node View replacements broken.png33.86 KBccjjmartin
#6 wysiwyg.tinymce_fullscreen.2903753.6.patch3.35 KBtwod
#2 wysiwyg-tinymce-fullscreen-2903753-2-D7.patch1.08 KBccjjmartin

Comments

ccjjmartin created an issue. See original summary.

ccjjmartin’s picture

ccjjmartin commented
StatusFileSize
new wysiwyg-tinymce-fullscreen-2903753-2-D7.patch1.08 KB
ccjjmartin’s picture

ccjjmartin commented
Related issues: +#1125582: TinyMCE fullscreen plugin deletes content
ccjjmartin’s picture

ccjjmartin commented
Related issues: +#2243413: Error when adding field items - Add another item
ccjjmartin’s picture

ccjjmartin commented
Status: Active » Needs review
twod’s picture

twod
Primary language Swedish
Location Sweden
commented
StatusFileSize
new wysiwyg.tinymce_fullscreen.2903753.6.patch3.35 KB

I'm trying to keep the internal Wysiwyg instance as the context wherever possible and only use Drupal.wysiwyg.editor.instance[editorName] to build a prototype for it so let's get it from the main TinyMCE instance instead.

Also noticed the TinyMCE 4 implementation wasn't keeping up (fullscreen is no longer a separate instance) so I included fixes for that.

ccjjmartin’s picture

ccjjmartin commented

Code and functional (ajax requests and maintaining content) both look good on TinyMCE 3. Going to look into TinyMCE4.

ccjjmartin’s picture

ccjjmartin commented
StatusFileSize
new TinyMCE 4.5.7 Node View replacements broken.png33.86 KB

When testing TinyMCE 4.5.7 + Drupal Core 7.56 I found that when I insert a link it saves the data to the database and displays the link within TinyMCE but when I go to view a node I am seeing:

some text [url=/test]Test[/url]

Maybe the prepare content for the plugins isn't replacing this properly ...

twod’s picture

twod
Primary language Swedish
Location Sweden
commented

Disable the BBCode plugin.

ccjjmartin’s picture

ccjjmartin commented

That fixed it. Is this a known issue with that plugin?

twod’s picture

twod
Primary language Swedish
Location Sweden
commented

It's designed to do that. You need a BBCode parser running as a text format filter to have any use for it though. (I don't even know if there are any for D8 yet)

ccjjmartin’s picture

ccjjmartin commented
Status: Needs review » Reviewed & tested by the community

This looks good to go then, great work!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: +panopoly

RTBC +1! This patch works great in my testing and we're now using it in Panopoly :-)

  • TwoD committed cb4accf on 6.x-2.x 
    - #2903753 by ccjjmartin, TwoD: Fixed regression: TinyMCE fullscreen...
  • TwoD committed 18832ab on 7.x-2.x
    - #2903753 by ccjjmartin, TwoD: Fixed regression: TinyMCE fullscreen...
twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting, patching and testing!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.