Problem/Motivation

Sites should not be forced to enable the language module in order to use this module.

Proposed resolution

Use a submodule and alter hooks in order to move the language negotiation out of the SendMailQueueWorker class.

Remaining tasks

Agree
Test
Code

CommentFileSizeAuthor
#9 interdiff.txt743 bytesplach
#8 qm-2897414-language_split-8.patch14.22 KBplach
#4 qm-2897414-language_split-4.patch14.22 KBplach

Comments

acbramley created an issue. See original summary.

sam152’s picture

sam152 commented

Just ran into this, agree, the dependency is quite weird.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Assigned: Unassigned » plach

Working on this

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Assigned: plach » Unassigned
Status: Active » Needs review
StatusFileSize
new qm-2897414-language_split-4.patch14.22 KB

This should be pretty much complete.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Category: Feature request » Task
Priority: Normal » Major
Issue tags: +stable release blocker

This was identified as the last (?) stable release blocker, so changing metadata accordingly.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue tags: -stable release blocker +D8 stable release blocker
catch’s picture

catch
he/him
Primary language English
commented

Looks sensible, one nit: 

+++ b/modules/queue_mail_language/src/Plugin/QueueWorker/LanguageAwareSendMailQueueWorker.php
@@ -0,0 +1,105 @@
+ * Sends emails form queue with language support.

Should this be 'emails form queue'? Maybe 'from'?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new qm-2897414-language_split-8.patch14.22 KB

Definitely "from" :)

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new interdiff.txt743 bytes

(forgot the interdiff)

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

  • sinn committed 08cd148 on 8.x-1.x 
    Issue #2897414: Move language negotiation into sub module. Fixed CS...
  • sinn committed ee75171 on 8.x-1.x authored by plach
    Issue #2897414 by plach: Move language negotiation into sub module

  • sinn committed a79f183 on 8.x-1.x 
    Issue #2897414: Move language negotiation into sub module. Fixed typo.
sinn’s picture

sinn commented
Status: Reviewed & tested by the community » Fixed

Great job! Thanks for your help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.