Comments

tatarbj created an issue. See original summary.

renatog’s picture

Assigned: tatarbj » renatog
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +ciandt-contrib
StatusFileSize
new3.4 KB
new99.78 KB
new67.46 KB

Hi people.

In attachment the patch with the fix.

Admin:

Title

Good Work and Good Weekend.

Regards.

tatarbj’s picture

Assigned: renatog » tatarbj

Let me start the review

tatarbj’s picture

Assigned: tatarbj » Unassigned
StatusFileSize
new3.4 KB
new1.27 KB

Tests are OK, but i've introduced under the D8 version a change because it seems a valid use case to use : character in a title that makes the code broken. So i've changed it to :: that makes no sense to be used in a title and also makes the code working in every cases :)
I attach an interdiff with the patch, please review them and let me know if you agree with it!
Bests,
Balazs.

renatog’s picture

Status: Needs review » Reviewed & tested by the community

Hi @tatarbj

Really makes sense use :: in this case.

Thank you for replicate fix on 8.x Works good.

+RTBC.

Good Weekend.

Regards.

tatarbj’s picture

Assigned: Unassigned » tatarbj
Status: Reviewed & tested by the community » Needs work

Following the changes under d8 issue, i'm backporting it here. patch comes in a few minutes.

tatarbj’s picture

Assigned: tatarbj » Unassigned
Status: Needs work » Needs review
StatusFileSize
new3.85 KB

Implemented changes from d8 version applied in the new patch here.
Review is needed.
Bests,
Balazs.

tatarbj’s picture

StatusFileSize
new4.38 KB
new1.85 KB

As we discovered with @gregboggs the new feature doesn't replace all the breadcrumbs, only the title (maybe it was originally planned like this, but why not allowing all the crumbs to be replaced!), i've made a new patch where it's possible. (Interdiff is also attached.)
Please review!

greg boggs’s picture

Status: Needs review » Reviewed & tested by the community

  • tatarbj committed 4e3b8e7 on 7.x-2.x
    Issue #2895974 by tatarbj, RenatoG: Replace Breadcrumb titles with...
tatarbj’s picture

Status: Reviewed & tested by the community » Fixed

Released

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.