Comments

Schaklaggedehu’s picture

The user writes the titles and their replacements like this: [Title:Replacement] separated by linebreaks.
Then the breadcrumb will show the replacement instead of the original title.

Schaklaggedehu created an issue. See original summary.

Schaklaggedehu’s picture

tipit’s picture

If null check in the form missing. Patch coming...

Schaklaggedehu’s picture

Emptycheck included.

Schaklaggedehu’s picture

Schaklaggedehu’s picture

greg boggs’s picture

Hey folks! Great Feature. The patch is rather large. Maybe there's some extra code polish?

Schaklaggedehu’s picture

StatusFileSize
new6.1 KB

Yes, accidentally reformated the code. Cleaned up now.

greg boggs’s picture

Perfect, thanks! Feel free to open a new issue for code formatting. Especially if I formatted it poorly.

greg boggs’s picture

Component: Miscellaneous » Code
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community
renatog’s picture

Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib
StatusFileSize
new52.5 KB
new49.4 KB
new79.65 KB

Hi people.

I applied the patch and works good for me.

Before:

After (Admin):

After:

Thank you very much for contributing.

Good Work.

Regards.

renatog’s picture

Status: Reviewed & tested by the community » Fixed

Fixed.

Committed in the dev branch.

Thank you very much people.

Good Work.

Regards.

tatarbj’s picture

Assigned: renatog » greg boggs
Status: Fixed » Needs work

Hey guys,
i would change a small thing that makes sense when an original title has a : character, so i'm creating a new patch based on dev version with this, also changing the description.

tatarbj’s picture

Assigned: greg boggs » tatarbj
tatarbj’s picture

Status: Needs work » Needs review
StatusFileSize
new1.5 KB

So here is the patch for the change that will make sure a non-used string will be the one where we split up the titles.
Please review (same fix as a backport comes under https://www.drupal.org/node/2895974

tatarbj’s picture

Assigned: tatarbj » Unassigned
renatog’s picture

Status: Needs review » Reviewed & tested by the community

Hi there.

I applied the patch and Works good like a #2895974: Replace Breadcrumb titles with aliases

Thank you very much @tatarbj.

Regards.

revagomes’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: -ciandt-contrib
StatusFileSize
new3.12 KB

Here goes a updated patch with a refactoring to prevent warnings on array_key_exists() function calls when applying title aliases replacement rules.

revagomes’s picture

Issue tags: +ciandt-contrib
tatarbj’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new3.59 KB

Hi @revagomes,
that's super helpful and nice solution, but as you didn't use the previously RTBCed patch, let me fix yours and put them together to RTBC as i've tested your patch and it works well!
Bests,
Balazs.

Marcos Lehmkuhl’s picture

Cool, I needed this patch and it's working.

Caralin’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.11 KB

The patch didn't apply against the latest dev for me any more.

I did a re-roll and had 2 conflicts in EasyBreadcrumbBuilder.php. The conflicts were in the handling of arrays (array() vs [] and array('-', '_') vs. ['-', '_'].

The patch worked fine when I tested it in a project.

greg boggs’s picture

Thanks Caralin!

Caralin’s picture

StatusFileSize
new3.22 KB

Spoke to soon. :(

Fixed the patch.

greg boggs’s picture

I'll have tatarbj take a look. Thanks for the updated patch. Commit credit coming your way soon!

tatarbj’s picture

Assigned: Unassigned » tatarbj

Doing it right away

tatarbj’s picture

Assigned: tatarbj » Unassigned
Status: Needs review » Reviewed & tested by the community

Ok folks, I think it's good enough to be committed to dev branch, nice work!

During the manual tests, I noticed this functionality is case sensitive as the whole breadcrumb logic changes the first letters to capital ones in the segments. As a new function got implemented in 7.x version, I'll open a follow-up issue to forward-port it to 8.x as it's a pretty nice solution to handle capitalization by the module with some edge cases - but for sure, it's not in the scope of this issue and i'm marking it RTBC!

@Greg as this is already released in 7.x, do you plan to release a new version with this for 8 or would you discuss some other things that could be forward-ported.
In the next 2 weeks i'll be more available then in drupalcon europe, where i'll be pretty limited as i'm going to Vienna - btw anyone of our active contributors comes too? We could meet there guys'n'girls :)

Bests,
Balazs.

greg boggs’s picture

Thanks @tarabj. I'll roll the release this week and spend the rest of it trying not to be jealous that you're going to Vienna. Oregon is on fire today. So, Vienna is sounding pretty amazing.

  • Greg Boggs committed ce7c08f on 8.x-1.x authored by Caralin
    Issue #2891840 by Schaklaggedehu, tatarbj, Caralin, revagomes, RenatoG,...
greg boggs’s picture

Status: Reviewed & tested by the community » Fixed

Hopefully I didn't muck this up. ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.