Form is not restrict to submit if the honeypot field element have 0 as value

Can you give a little more detail, like a set of steps I could follow to reproduce this issue?

Are you adding 0 as the 'Honeypot element name' on the configuration page? Or for the time limit? Or is it something you're doing in a custom API integration?

Or maybe do you mean that on the site's frontend, if you visit a Honeypot-protected form, and enter 0 as the value in the invisible honeypot field, then Honeypot allows the form to be submitted, even though there technically was a value in the field?

Sounds like a bug! Strict typing would catch that, but in the meantime, this should be fixed and a test case added to make sure it doesn’t happen again. Switching to 'bug report'.

Looks good, just needs a test. Then we'll need to port this test and fix to Drupal 8 as well.

@only4kaustav, the status of this issue should be 'Needs work' as it still needs a test.

Test added.

LGTM, going to merge this patch to D7, and once that's done change version on this to D8 for the port.

Patch is in 7.x-dev, needs to be ported now to D8.

Attaching ported patches; worked locally, just want to see what testbot thinks.

Eh... uploaded the same patch twice. I hate patch workflows :P — correct full patch attached to _this_ comment.

Fixed in 7.x and 8.x.

I feel like this solution is needlessly convoluted. In my opinion this check should suffice:

if ($element['#value'] !== '') {