Looking through the plugin helper service just now (to shamelessly steal it for the Autocomplete module), I realized that, when moving it from the index to a service, we didn't adapt the error detection to the new mechanism. While we now retrieve the plugin manager just from the service class' properties, we still check for a ServiceNotFoundException to see whether $type is known.
No real problem there, since those methods are protected and thus only called with the (valid) $type parameters listed in the class itself, but still, sloppy coding.

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Status: Active » Needs review
StatusFileSize
new2.03 KB
borisson_’s picture

Status: Needs review » Reviewed & tested by the community

  • drunken monkey committed 4637cf1 on 8.x-1.x
    Issue #2891246 by drunken monkey: Fixed error detection in plugin helper...
drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.