D8 port of maintenance200 module uses MENU_SITE_OFFLINE constant in event subscriber that is not supported by D8 core.

Attached is the patch that provides D8 support and uses the interface for the maintenance mode service provided by the core. At the same time module structure has been changed according to coding standards. Hopefully ok.

CommentFileSizeAuthor
#9 interdiff-7-9.txt730 bytesr.nabiullin
#9 maintenance200-d8-support-9.patch16.9 KBr.nabiullin
#7 maintenance200-d8-support-7.patch16.89 KBr.nabiullin
#7 interdiff-2-7.txt7.35 KBr.nabiullin
#3 maintenance200-d8-support-2.patch15.44 KBmitrpaka
maintenance200-d8-support.patch9.49 KBmitrpaka

Comments

mitrpaka created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, maintenance200-d8-support.patch, failed testing. View results

mitrpaka’s picture

mitrpaka commented
Status: Needs work » Needs review
StatusFileSize
new maintenance200-d8-support-2.patch15.44 KB

Here is updated patch file as first patch file is corrupted (and missing files).

mitrpaka’s picture

mitrpaka commented
hkirsman’s picture

hkirsman commented

This must be added as this is not merely constant issue but refactoring for make the module work at all for latest D8!

hkirsman’s picture

hkirsman commented
Status: Needs review » Reviewed & tested by the community
r.nabiullin’s picture

r.nabiullin commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff-2-7.txt7.35 KB
new maintenance200-d8-support-7.patch16.89 KB

Fixed code style
Fixed installing config and schema

hkirsman’s picture

hkirsman commented

Wondering why changed some variables from protected to public? @r.nabiullin

r.nabiullin’s picture

r.nabiullin commented
StatusFileSize
new maintenance200-d8-support-9.patch16.9 KB
new interdiff-7-9.txt730 bytes

@hkirsman really no reason for it. Fixed

hkirsman’s picture

hkirsman commented
Status: Needs review » Reviewed & tested by the community

  • Barrett committed ea87aa2 on 8.x-1.x 
    Issue #2885750 by r.nabiullin, mitrpaka: D8 support - MENU_SITE_OFFLINE...
barrett’s picture

barrett commented

Thank you @hkrisman and @r.nabiullin. I believe I captured all the changes reflect here and the module seems to be working as expected at this time.

barrett’s picture

barrett commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.