We have to convert the module to short array as per new coding standard

CommentFileSizeAuthor
#3 fitbit_array_search_results.png56.52 KBdhruveshdtripathi
#2 2880250-2.patch2.04 KBPavan B S

Issue fork fitbit-2880250

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Status: Active » Needs review
StatusFileSize
new 2880250-2.patch2.04 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new fitbit_array_search_results.png56.52 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 6 array declarations, after applying patch there is 1. That 1 array declaration is in_array.

Good work!

m4olivei made their first commit to this issue’s fork.

m4olivei opened merge request !1

  • m4olivei committed 345945c on 8.x-1.x 
    Issue #2880250 by m4olivei, Pavan B S: Convert module to use short array...
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Merged to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.