Closed (fixed)
Project:
Views Infinite Scroll
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
18 May 2017 at 23:24 UTC
Updated:
8 May 2018 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
acbramley commentedComment #3
sam152 commentedLooking good, thanks for the test. Review as follows.
Is @token_name the approach the rest of views uses? I think they faked twig and started using {{ foo }} for their tokens? There might be some views methods that deal with this.
Lets move everything that calculates the number of items left into a getNumberItemsLeft method. Almost a good candidate for a unit test.
strtr will do key/value replacements without array_keys/array_values.
We can probably use #prefix/#suffix on the list to get a description in there, instead of rendering early.
<3
Comment #4
acbramley commentedThanks for the review!
1. Admittedly I'm not too sure, I was going off what the Result area plugin does. Happy to switch it up though.
2. Good idea, that was lazy of me!
3. Ah ofcourse, done!
4. Good idea!
5. :)
Comment #5
fenstratStraight reroll of #4 as it no longer applied.
Comment #6
hugronaphor commentedMy use-case is to have a string as: Load More @next_page_count more tickets (@total tickets total)
So I'm adding @total token as well.
Comment #8
hugronaphor commentedComment #9
sam152 commentedComment #11
sam152 commentedThis dropped off the radar. Looks good to go for me.