Add to Cal module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#5 2875116-5.patch7.4 KBsuresh prabhu parkala
#3 addtocal_array_search_list.png44.02 KBdhruveshdtripathi
#2 short_array_syntax-2875116-2.patch11.62 KBMunavijayalakshmi

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
StatusFileSize
new short_array_syntax-2875116-2.patch11.62 KB
dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new addtocal_array_search_list.png44.02 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 47 array declarations, after applying patch there are 3. Those 3 arrays are in_array.

Good work!

wxactly’s picture

wxactly commented
Status: Reviewed & tested by the community » Needs work

Thanks y'all - unfortunately this patch does not apply cleanly on 8.x-1.x

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 2875116-5.patch7.4 KB

Re-rolled patch please review!

wxactly’s picture

wxactly commented
Status: Needs review » Fixed

Thanks! Fixed in 8.x-1.x

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

@wxactly thanks for the fixes! Looks good.

~G

wxactly’s picture

wxactly commented
Status: Fixed » Closed (fixed)