Replace all deprecated uses in module.

CommentFileSizeAuthor
#11 2856356-11.patch2.71 KBgeerlingguy
#7 honeypot-replace_all_deprecated_uses-2856356-7.patch5.4 KBbkhandruk
#5 honeypot-replace_all_deprecated_uses-2856356-5.patch5.45 KBbkhandruk
#2 honeypot-replace_all_deprecated_uses-2856356-2.patch4.85 KBbkhandruk

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

bkhandruk commented
Assigned: bkhandruk » Unassigned
Status: Active » Needs review
StatusFileSize
new honeypot-replace_all_deprecated_uses-2856356-2.patch4.85 KB

Replaced all deprecated uses in module.
Also added dependency injection for HoneypotSettingsController.

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Reviewed & tested by the community

LGTM.

geerlingguy’s picture

geerlingguy commented
Status: Reviewed & tested by the community » Needs work

After working on #2860293: Fix some PAReview.sh suggestions I realized I fixed a few of these occurrences, because I had forgotten to merge this patch first, oops!

Can you reroll, as there are still a few other instances where we can tidy things up.

bkhandruk’s picture

bkhandruk commented
Status: Needs work » Needs review
StatusFileSize
new honeypot-replace_all_deprecated_uses-2856356-5.patch5.45 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 5: honeypot-replace_all_deprecated_uses-2856356-5.patch, failed testing.

bkhandruk’s picture

bkhandruk commented
Status: Needs work » Needs review
StatusFileSize
new honeypot-replace_all_deprecated_uses-2856356-7.patch5.4 KB

Fixed.

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Reviewed & tested by the community

LGTM, this time I'll get it committed!

geerlingguy’s picture

geerlingguy commented
Status: Reviewed & tested by the community » Fixed
geerlingguy’s picture

geerlingguy commented
Status: Fixed » Needs review
StatusFileSize
new 2856356-11.patch2.71 KB

A couple more small corrections as a result of updated code standards review (see attached patch).

  • geerlingguy committed fff653c on 8.x-1.x 
    Issue #2856356 by geerlingguy: Fix remaining coding standards issues.
geerlingguy’s picture

geerlingguy commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.