Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Replace all deprecated uses in module.
Comment | File | Size | Author |
---|---|---|---|
#11 | 2856356-11.patch | 2.71 KB | geerlingguy |
| |||
#7 | honeypot-replace_all_deprecated_uses-2856356-7.patch | 5.4 KB | bkhandruk |
|
Comments
Comment #2
bkhandruk CreditAttribution: bkhandruk commentedReplaced all deprecated uses in module.
Also added dependency injection for HoneypotSettingsController.
Comment #3
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commentedLGTM.
Comment #4
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commentedAfter working on #2860293: Fix some PAReview.sh suggestions I realized I fixed a few of these occurrences, because I had forgotten to merge this patch first, oops!
Can you reroll, as there are still a few other instances where we can tidy things up.
Comment #5
bkhandruk CreditAttribution: bkhandruk commentedRerolled.
Comment #7
bkhandruk CreditAttribution: bkhandruk commentedFixed.
Comment #9
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commentedLGTM, this time I'll get it committed!
Comment #10
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commentedComment #11
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commentedA couple more small corrections as a result of updated code standards review (see attached patch).
Comment #13
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented