The sensor parameter is no longer required for the Google Maps JavaScript API.
Google recommends to remove the sensor parameter from the script element:
https://developers.google.com/maps/documentation/javascript/error-messag...

Issue fork gmap-2852988

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dzutaro created an issue. See original summary.

dzutaro’s picture

Status: Active » Needs review
StatusFileSize
new1.25 KB

I made a patch.

dzutaro’s picture

dzutaro’s picture

mustanggb’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: gmap-remove_sensor_parameter-2852988-1.patch, failed testing.

dpovshed’s picture

Status: Needs work » Needs review
StatusFileSize
new576 bytes
new1.78 KB

Updating the tests as well.

mustanggb’s picture

Status: Needs review » Reviewed & tested by the community

Nicely done.

podarok’s picture

Version: 7.x-2.x-dev » 3.0.x-dev
Status: Reviewed & tested by the community » Needs work

doesn't apply

the_g_bomb made their first commit to this issue’s fork.

the_g_bomb’s picture

Re-rolling against 3.0.x

the_g_bomb’s picture

Status: Needs work » Needs review

  • the_g_bomb committed fbf1ef8 on 3.0.x
    Issue #2852988 Remove the sensor parameter from the script element
    

  • the_g_bomb committed fbf1ef8 on 7.x-2.x
    Issue #2852988 Remove the sensor parameter from the script element
    
podarok’s picture

Version: 3.0.x-dev » 3.0.3
Status: Needs review » Fixed

Thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.