CommentFileSizeAuthor
#8 this_t_should_be-2843899-8.patch6.34 KBdhruveshdtripathi
#2 yoast_seo_2843899_1.patch4.89 KBnehakhadke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commented
FileSize
yoast_seo_2843899_1.patch4.89 KB

robertragas’s picture

robertragas CreditAttribution: robertragas commented

Thanks for the patch.

robertragas’s picture

robertragas CreditAttribution: robertragas commented
Status: Needs review » Fixed
robertragas’s picture

robertragas CreditAttribution: robertragas commented
Status: Fixed » Needs work

Re-opened and reverted patch because of crash it produces.

Error: Call to undefined method Drupal\yoast_seo\YoastSeoFieldManager::t() in Drupal\yoast_seo\YoastSeoFieldManager->setFieldsConfiguration() (line 274 of /yoast_seo/src/YoastSeoFieldManager.php) #0

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi

class YoastSeoFieldManager in /src/YoastSeoFieldManager.php does not extend any other class, so t() functions in that class will not be replaced. Working on it.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
FileSize
this_t_should_be-2843899-8.patch6.34 KB

I've created patch from scratch. Please run tests before committing.

robertragas’s picture

robertragas CreditAttribution: robertragas commented

Great! This one isn't giving any errors. Thanks.

robertragas’s picture

robertragas CreditAttribution: robertragas commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.