As per coding standard documentation at https://www.drupal.org/coding-standards/docs#file, the @file docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#11 remove_file_tag-2843812-11.patch870 bytesalex_optim
#9 2843812-6.patch364 bytesPavan B S
#4 remove@file_2843812_1.patch-4.patch364 bytesPavan B S
#2 remove@file_2843812_1.patch725 bytesnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new remove@file_2843812_1.patch725 bytes

Status: Needs review » Needs work

The last submitted patch, 2: remove@file_2843812_1.patch, failed testing.

Pavan B S’s picture

Pavan B S commented
StatusFileSize
new remove@file_2843812_1.patch-4.patch364 bytes

Re-applying the patch, for testing removed @file from test file for checking.

Pavan B S’s picture

Pavan B S commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: remove@file_2843812_1.patch-4.patch, failed testing.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs work » Reviewed & tested by the community

Hi Pavan

Re-upload the patch after removing @ sign from patch name.

Thank you

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Reviewed & tested by the community » Needs work
Pavan B S’s picture

Pavan B S commented
StatusFileSize
new 2843812-6.patch364 bytes

Reapplying the patch, as per the suggestion from comment #7

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs work » Reviewed & tested by the community

Patch #9 is OK!

alex_optim’s picture

alex_optim
Location Tallinn
commented
StatusFileSize
new remove_file_tag-2843812-11.patch870 bytes

Tag @file used in not one place in this module. So I remove this tag from all places.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

look good

alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Reviewed & tested by the community » Patch (to be ported)

  • alex_optim committed bc343ea on 8.x-1.x 
    Issue #2843812 by alex_optim, pifagor : Remove @file tag docblock from...
alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.