Blocked on #2763787: Upgrade random_compat to latest version

CommentFileSizeAuthor
#17 2825309-3.patch1.81 MBlarowlan
#15 2825309-2.patch1.81 MBlarowlan
#13 2825309.patch1.81 MBlarowlan
#5 2825309-5.patch368 bytescosmicdreams

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Related issues: +#2763787: Upgrade random_compat to latest version

.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Postponed » Active

Blocker is in

cosmicdreams’s picture

cosmicdreams commented

cool, so would you be ok if I submitted a patch to update this?

cosmicdreams’s picture

cosmicdreams commented
StatusFileSize
new 2825309-5.patch368 bytes

Here's the patch

geerlingguy’s picture

geerlingguy commented
Status: Active » Needs review

@larowlan - When we try getting this tested in our project, we're hitting a hard blocker. We can't patch the module's composer.json using composer-patches (see: https://github.com/cweagans/composer-patches#patches-containing-modifica...), so we can't require the later version of the module and get entity_pilot_git working.

Is it possible for you to commit the above update, or are there any other changes required to get things working?

Status: Needs review » Needs work

The last submitted patch, 5: 2825309-5.patch, failed testing.

geerlingguy’s picture

geerlingguy commented 
Fatal error: Class 'Crypto' not found in /var/www/html/modules/contrib/entity_pilot/src/Encryption/Encrypter.php on line 26

It looks like there will need to be some other changes in addition to just bumping the version to 2.0 :/

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

As mentioned on slack, there is quite a lot more involved.

https://github.com/defuse/php-encryption/blob/master/docs/UpgradingFromV...

We need an upgrade path and upgrade path tests as well, both for the accounts and the departures (need to be resent once new key is generated).

It's about 6-8 hours work, and is on my radar for April or so.

arknoll’s picture

arknoll commented

Has any progress been made on this?

The Lightning distribution now has a hard composer conflict on defuse/php-encryption. It requires defuse/php-encryption ^2.1

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

No sorry, I haven't had time.

I would welcome patches and are willing to provide guidance to anyone who is interested in working on this.

amit.sharma.aust’s picture

amit.sharma.aust commented

I need to update php version to 7.2 which doesn’t have mcrypt anymore. entity_pilot has dependency on defuse/php-encryption ~1.2 which further has dependency on mcrypt. I am looking forward to see newer version of entity_pilot with no dependency on mcrypt.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 2825309.patch1.81 MB

Achievement unlocked: upload a patch from the dentist waiting room

Status: Needs review » Needs work

The last submitted patch, 13: 2825309.patch, failed testing. View results

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 2825309-2.patch1.81 MB

Status: Needs review » Needs work

The last submitted patch, 15: 2825309-2.patch, failed testing. View results

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 2825309-3.patch1.81 MB

Status: Needs review » Needs work

The last submitted patch, 17: 2825309-3.patch, failed testing. View results

  • larowlan committed a58b433 on 8.x-1.x 
    Issue #2825309 by larowlan, cosmicdreams: Update to defuse/php-...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Fixed

Same fails in HEAD

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.