Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.On an existing node with media, upon selecting new media, then the notice below is thrown:
Error:
Undefined index: data-entity-embed-display-settings in Drupal\entity_embed\Form\EntityEmbedDialog->submitEmbedStep() line 735
Effect:
Users are stuck on the "Select entities" step (see screenshot attached).
Build:
Lightning 1.06
Related Issues:
Similar issue fixed in #2786493: EntityEmbedDialog causes undefined index notice if no embed display settings are presented to the user
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | screenshot.png | 9.3 KB | recrit |
| #3 | entity_embed-line735-index-missing-2815847-2.patch | 854 bytes | recrit |
| |||
Comments
Comment #2
recrit CreditAttribution: recrit commentedPatch attached adds an empty check before accessing the array index.
Comment #3
recrit CreditAttribution: recrit commentedrenamed patch file to match correct line number.
Comment #4
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedLooks good to me. Could you provide more background info (which display plugin, how embed code for existing embed looks, steps to reproduce)?
Comment #5
recrit CreditAttribution: recrit commentedComment #6
recrit CreditAttribution: recrit commented@slashrsm - it was the lightning media browser.
I uploaded the missing screenshot: https://www.drupal.org/files/issues/screenshot_257.png
It would get stuck / stopped at that step, and then the error message would be logged.
Comment #7
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedScreenshot doesn't say much. Could you share steps to reproduce this in Lightning? I doubt that this error can stop embedding from working all together. It is just a notice after all. What happens if you press "Next"?
Does the patch fix the problem with embed stuck on that page?
Comment #8
recrit CreditAttribution: recrit commentedPatch fixes the issue. Same issue as seen on #2786493: EntityEmbedDialog causes undefined index notice if no embed display settings are presented to the user only for existing content.
Comment #10
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedCommitted. Thanks.