On an existing node with media, upon selecting new media, then the notice below is thrown:
Error:
Undefined index: data-entity-embed-display-settings in Drupal\entity_embed\Form\EntityEmbedDialog->submitEmbedStep() line 735

Effect:
Users are stuck on the "Select entities" step (see screenshot attached).

Build:
Lightning 1.06

Related Issues:
Similar issue fixed in #2786493: EntityEmbedDialog causes undefined index notice if no embed display settings are presented to the user

CommentFileSizeAuthor
#5 screenshot.png9.3 KBrecrit
#3 entity_embed-line735-index-missing-2815847-2.patch854 bytesrecrit
#2 entity_embed-line175-index-missing-2815847-2.patch854 bytesrecrit

Comments

recrit created an issue. See original summary.

recrit’s picture

recrit commented
Status: Active » Needs review
StatusFileSize
new entity_embed-line175-index-missing-2815847-2.patch854 bytes

Patch attached adds an empty check before accessing the array index.

recrit’s picture

recrit commented
StatusFileSize
new entity_embed-line735-index-missing-2815847-2.patch854 bytes

renamed patch file to match correct line number.

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +D8Media

Looks good to me. Could you provide more background info (which display plugin, how embed code for existing embed looks, steps to reproduce)?

recrit’s picture

recrit commented
StatusFileSize
new screenshot.png9.3 KB
recrit’s picture

recrit commented

@slashrsm - it was the lightning media browser.
I uploaded the missing screenshot: https://www.drupal.org/files/issues/screenshot_257.png
It would get stuck / stopped at that step, and then the error message would be logged.

slashrsm’s picture

slashrsm commented

Screenshot doesn't say much. Could you share steps to reproduce this in Lightning? I doubt that this error can stop embedding from working all together. It is just a notice after all. What happens if you press "Next"?

Does the patch fix the problem with embed stuck on that page?

recrit’s picture

recrit commented

Patch fixes the issue. Same issue as seen on #2786493: EntityEmbedDialog causes undefined index notice if no embed display settings are presented to the user only for existing content.

  • slashrsm committed 0a8d4b3 on 8.x-1.x authored by recrit 
    Issue #2815847 by recrit, slashrsm: Fix - Undefined index: data-entity-...
slashrsm’s picture

slashrsm commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.