Module has some code styling issues which should be fixed to bring the code up to date with current Drupal standards.

http://pareview.sh/pareview/httpgitdrupalorgprojectextlinkgit-8x-1x

Steps to Commit

  1. Commit the patch to a seperate branch coding-standards
  2. Go to pareview.sh and then specify the url http://git.drupal.org/project/extlink.git coding-standards
  3. Submit to check all coding standards got fixed , if not then repeat step 1 to 3
  4. if all coding standards got fixed, commit to 8.x-1.x, Delete the coding-standards branch
CommentFileSizeAuthor
#9 2798439-9.patch861 bytesnaveenvalecha
#2 2798439-2.patch6.69 KBnaveenvalecha

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Active » Needs review
Parent issue: #2748635: Code Standards Cleanup »
StatusFileSize
new 2798439-2.patch6.69 KB

  • elachlan committed 24c828a on 8.x-1.x 
    Issue #2798439 by naveenvalecha: Code Standards Cleanup

  • elachlan committed f050c90 on 8.x-1.x 
    Issue #2798439 by naveenvalecha: Code Standards Cleanup

  • elachlan committed 436b71b on 8.x-1.x 
    Issue #2798439 by naveenvalecha: Code Standards Cleanup

  • elachlan committed 2b8a859 on 8.x-1.x 
    Issue #2798439 by naveenvalecha: Code Standards Cleanup
elachlan’s picture

elachlan commented

Unsure on this error.

FILE: /var/www/drupal-7-pareview/pareview_temp/extlink.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
18 | WARNING | Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
18 | WARNING | Do not concatenate strings to translatable strings, they
| | should be part of the t() argument and you should use
| | placeholders
--------------------------------------------------------------------------
naveenvalecha’s picture

naveenvalecha
He/Him
commented
StatusFileSize
new 2798439-9.patch861 bytes

This will fix 2798439-8

  • elachlan committed 88e7f4e on 8.x-1.x 
    Issue #2798439 by naveenvalecha: Code Standards Cleanup
elachlan’s picture

elachlan commented
Status: Needs review » Fixed

All fixed.

The minified js error I don't think we can do much about. The file probably shouldn't be there as its bundled and minified by drupal anyway.

Status: Fixed » Needs work

The last submitted patch, 9: 2798439-9.patch, failed testing.

  • elachlan committed 62eca1c on 8.x-1.x 
    Issue #2798439 by naveenvalecha: Code Standards Cleanup
elachlan’s picture

elachlan commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.