Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Module has some code styling issues which should be fixed to bring the code up to date with current Drupal standards.
http://pareview.sh/pareview/httpgitdrupalorgprojectextlinkgit-8x-1x
Steps to Commit
- Commit the patch to a seperate branch
coding-standards
- Go to pareview.sh and then specify the url
http://git.drupal.org/project/extlink.git coding-standards
- Submit to check all coding standards got fixed , if not then repeat step 1 to 3
- if all coding standards got fixed, commit to 8.x-1.x, Delete the
coding-standards
branch
Comment | File | Size | Author |
---|---|---|---|
#9 | 2798439-9.patch | 861 bytes | naveenvalecha |
#2 | 2798439-2.patch | 6.69 KB | naveenvalecha |
|
Comments
Comment #2
naveenvalechaComment #8
elachlan CreditAttribution: elachlan commentedUnsure on this error.
Comment #9
naveenvalechaThis will fix 2798439-8
Comment #11
elachlan CreditAttribution: elachlan commentedAll fixed.
The minified js error I don't think we can do much about. The file probably shouldn't be there as its bundled and minified by drupal anyway.
Comment #14
elachlan CreditAttribution: elachlan commented