Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Something wrong with the svg_logo.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | eldir-notice_undefined-2786149-4.patch | 2.49 KB | jacob.embree |
| #2 | notice_undefined-2786149-2.patch | 529 bytes | helmo |
Comments
Comment #2
helmo commentedHmm, this seems to happen when you set a custom logo image.
In template.php we check the name and only then set $variables['svg_logo'].
This patch is a quick fix. I hope someone with more theming background can improve it.
Comment #3
rajab natshahComment #4
jacob.embree commentedThis patch checks in every case for the existence of $svg_logo before using it and falls back to $logo if it isn't set. It also removes the "onerror" HTML attribute in those instances because I think that was previously the fall back mechanism that I am now replacing.
Comment #5
helmo commented@jacob.embree from you comment it sounds like you agree with the current patch from #2. Are you working on a better approach that would force to to the 4.x branch?
Other wise I'd like to just commit this next week for the 3.8 Aegir release.
Comment #6
jacob.embree commentedI forgot to upload the patch I did.
I don't actually know the difference between 3.x and 4.x. I just did 4.x because it's the latest, but it applies to both.
Comment #8
helmo commentedThanks, committed.