We need to adjust the code as we do in #2751845: Twitter widgets deprecated? so we can use this module.
I have renamed widget_id to username because there is no widget ID anymore. I also renamed width and height attribute to data-width/height.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | twitter_block-2783737-username_instead_widgetid-12.patch | 6.4 KB | yannickoo |
Comments
Comment #2
yannickooComment #4
yannickooComment #6
yannickooFinally :D
Comment #7
yannickooOkay last try: I removed the description of the username field because it's self-explaining.
Comment #8
naveenvalechaThis patch is doing changes in the schema. It needs an hook_post_upate_NAME function to update the existing blocks.
+1
Unrelated change. Do it in another followup issue.
Unrelated change. Do it in another followup issue.
Comment #9
yannickooHey :) First of all thank you for reviewing my changes! I guess these changes cannot land in the current branch because there are breaking changes. I mean we cannot transform former widget IDs to usernames, so we need to create a new branch
8.x-3.x. People cannot simply upgrade the module.Regarding 3 & 4: These changes are necessary to make the block compatible with the latest documentation, I see here no reason to move these 2 dimension attribute changes into a seperate issue.
What do you think? :)
PS: When you agree on
3.xbranch you need to push that branch so I can create proper patches for it.Comment #10
naveenvalechaAgreed with the new branch name as its not possible for find the twitter handler from widget id. Created a new branch forked from 8.x-2.x
Comment #11
naveenvalechaComment #12
yannickooI guess we can use the patch from #7 but I have also created a fresh patch base on the new branch :)
Comment #13
pheski commentedHere is relevant info from Twitter:
Comment #14
Pascal- commentedpatch works for me
Comment #15
Pascal- commentedComment #16
naveenvalechaCommitted and pushed to 8.x-3.x
There's not any upgrade path from 8.x-2.x to 8.x-3.x
//Naveen