Links that are rendered with a css rule of display: block gain the .ext class but no appended span.
Not sure if there is reasoning behind this and it is possible to workaround but I have tested some scenarios locally by altering this statement if ($link.css('display') === 'inline' || $link.css('display') === 'inline-block') and have noticed no issues.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | extlink-allow-display-block-2773545-13.patch | 865 bytes | xlin |
| #12 | extlink-allow-display-block-2773545-12.patch | 676 bytes | xlin |
| #11 | extlink-allow-display-block-2773545-11.patch | 865 bytes | xlin |
| #10 | extlink-allow-display-block-2773545-10.patch | 766 bytes | pieterdc |
| #5 | extlink-allow-display-block-2773545-5-D8.patch | 701 bytes | tostinni |
Comments
Comment #2
tostinni commentedI found the same on the Drupal 7 version, so adding
blockto this statement allow the span to be added.I attach a patch for D7 and for D8.
Comment #3
rconstantine commentedi needed to apply the same change to the minified version. syntax was slightly different. in any case, it works.
Comment #4
elachlan commentedPlease re-roll the patch. It does not apply. It needs to be against dev.
Comment #5
tostinni commentedHere it is.
Thanks
Comment #7
elachlan commentedThanks
Comment #9
spadxiii commentedDoes this need to be backported to D7 ?
ps. the patch in #2 still applies to the latest D7-release.
Comment #10
pieterdc@SpadXIII it does need to be backported to D7.
Rerolled the patch against 7.x-1.x
See attached.
Dear maintainer, can you reopen the issue and change the issue version to 7.x-1.x-dev?
I already added 'Needs backport to D7' tag.
Comment #11
xlin commentedRerolled against 7.x-1.x, patch attached.
Comment #12
xlin commentedRerolled against 7.x-1.2.0, patch attached.
Comment #13
xlin commentedRerolled against 7.x-1.2.1, patch attached.