Links that are rendered with a css rule of display: block gain the .ext class but no appended span.
Not sure if there is reasoning behind this and it is possible to workaround but I have tested some scenarios locally by altering this statement if ($link.css('display') === 'inline' || $link.css('display') === 'inline-block') and have noticed no issues.

CommentFileSizeAuthor
#13 extlink-allow-display-block-2773545-13.patch865 bytesxlin
#12 extlink-allow-display-block-2773545-12.patch676 bytesxlin
#11 extlink-allow-display-block-2773545-11.patch865 bytesxlin
#10 extlink-allow-display-block-2773545-10.patch766 bytesPieterDC
#5 extlink-allow-display-block-2773545-5-D8.patch701 bytestostinni
#2 extlink-allow-display-block-2773545-2.patch737 bytestostinni
#2 extlink-allow-display-block-2773545-2-D8.patch704 bytestostinni
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thecraighammond created an issue. See original summary.

tostinni’s picture

tostinni CreditAttribution: tostinni at Agence Propal commented
Status: Active » Needs work
FileSize
extlink-allow-display-block-2773545-2-D8.patch704 bytes
extlink-allow-display-block-2773545-2.patch737 bytes

I found the same on the Drupal 7 version, so adding block to this statement allow the span to be added.

I attach a patch for D7 and for D8.

rconstantine’s picture

rconstantine CreditAttribution: rconstantine commented

i needed to apply the same change to the minified version. syntax was slightly different. in any case, it works.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Version: 8.x-1.0-alpha2 » 8.x-1.x-dev

Please re-roll the patch. It does not apply. It needs to be against dev.

tostinni’s picture

tostinni CreditAttribution: tostinni at Agence Propal commented
Status: Needs work » Needs review
FileSize
extlink-allow-display-block-2773545-5-D8.patch701 bytes

Here it is.
Thanks

  • elachlan committed d46ae84 on 8.x-1.x authored by tostinni 
    Issue #2773545 by tostinni: Links with display: block; do not get...
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

SpadXIII’s picture

SpadXIII CreditAttribution: SpadXIII at ezCompany commented

Does this need to be backported to D7 ?
ps. the patch in #2 still applies to the latest D7-release.

PieterDC’s picture

PieterDC
Primary language Dutch
Location Ghent
CreditAttribution: PieterDC at Randstad Digital for Government of Flanders commented
Issue tags: +Needs backport to D7
FileSize
extlink-allow-display-block-2773545-10.patch766 bytes

@SpadXIII it does need to be backported to D7.
Rerolled the patch against 7.x-1.x
See attached.

Dear maintainer, can you reopen the issue and change the issue version to 7.x-1.x-dev?
I already added 'Needs backport to D7' tag.

xlin’s picture

xlin CreditAttribution: xlin as a volunteer commented
FileSize
extlink-allow-display-block-2773545-11.patch865 bytes

Rerolled against 7.x-1.x, patch attached.

xlin’s picture

xlin CreditAttribution: xlin as a volunteer commented
FileSize
extlink-allow-display-block-2773545-12.patch676 bytes

Rerolled against 7.x-1.2.0, patch attached.

xlin’s picture

xlin CreditAttribution: xlin as a volunteer commented
FileSize
extlink-allow-display-block-2773545-13.patch865 bytes

Rerolled against 7.x-1.2.1, patch attached.