CommentFileSizeAuthor
#2 vis-js-coding-standards-2771485-2.patch7.25 KBnod_

Comments

Sam152 created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
commented
StatusFileSize
new vis-js-coding-standards-2771485-2.patch7.25 KB

It's a slightly more involved patch than just coding standard fix but here it is, feel free to pick and choose what you want and what you don't.

  • Replaced snake case with camel case
  • Make use of data attributes instead of class names (so that themers don't break functionality)
  • Added Drupal.debounce on the scroll event to keep processing light on scroll
  • Added some docs for the behavior
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Needs review
sam152’s picture

sam152 commented
Status: Needs review » Fixed

All welcome additions. Thank you.

  • Sam152 committed d007197 on 8.x-1.x authored by nod_ 
    Issue #2771485 by nod_: Adhere to JavaScript coding standards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.