Rabbit Hole form appears on node/X/delete page. It shouldn't be there probably.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2744329-4-form-appears-delete-form.patch | 1.58 KB | ieguskiza |
| #2 | 2744329-2-form-appears-delete-form.patch | 1.19 KB | phillipHG |
Rabbit Hole form appears on node/X/delete page. It shouldn't be there probably.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2744329-4-form-appears-delete-form.patch | 1.58 KB | ieguskiza |
| #2 | 2744329-2-form-appears-delete-form.patch | 1.19 KB | phillipHG |
Comments
Comment #2
phillipHG commentedWon't allow the settings form to appear on delete form
Comment #3
phillipHG commentedComment #4
ieguskiza commentedHi,
the patch solves the issue but I think we should take into account other delete forms such as:
* Canceling a user account
* Deleting entity bundles (such as content types and vocabularies
I have extended the provided patch in order to fix this other forms as well.
Comment #5
ieguskiza commentedComment #7
dylan donkersgoed commentedI reviewed and tested this and it seems okay, so I committed it.
This might recur for more exotic use cases - e.g. if someone provides a rabbit hole plugin for a custom entity, if a custom module adds extra node operations that shouldn't have rabbit hole settings. If so, I might revisit this later and try a more complex solution - probably provide a whitelist of operations in an entity plugin method with some reasonable defaults if it's not overridden.
Comment #9
phillipHG commented