Rabbit Hole form appears on node/X/delete page. It shouldn't be there probably.

Comments

temkin created an issue. See original summary.

phillipHG’s picture

StatusFileSize
new1.19 KB

Won't allow the settings form to appear on delete form

phillipHG’s picture

Status: Active » Needs review
ieguskiza’s picture

Issue tags: +Dublin2016
StatusFileSize
new1.58 KB

Hi,
the patch solves the issue but I think we should take into account other delete forms such as:
* Canceling a user account
* Deleting entity bundles (such as content types and vocabularies

I have extended the provided patch in order to fix this other forms as well.

ieguskiza’s picture

Issue tags: -Dublin2016

dylan donkersgoed’s picture

Status: Needs review » Fixed

I reviewed and tested this and it seems okay, so I committed it.

This might recur for more exotic use cases - e.g. if someone provides a rabbit hole plugin for a custom entity, if a custom module adds extra node operations that shouldn't have rabbit hole settings. If so, I might revisit this later and try a more complex solution - probably provide a whitelist of operations in an entity plugin method with some reasonable defaults if it's not overridden.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

phillipHG’s picture