Closed (fixed)
Project:
Rabbit Hole
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Jun 2016 at 18:58 UTC
Updated:
9 Jan 2018 at 19:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
philliphg commentedWon't allow the settings form to appear on delete form
Comment #3
philliphg commentedComment #4
ieguskiza commentedHi,
the patch solves the issue but I think we should take into account other delete forms such as:
* Canceling a user account
* Deleting entity bundles (such as content types and vocabularies
I have extended the provided patch in order to fix this other forms as well.
Comment #5
ieguskiza commentedComment #7
dylan donkersgoed commentedI reviewed and tested this and it seems okay, so I committed it.
This might recur for more exotic use cases - e.g. if someone provides a rabbit hole plugin for a custom entity, if a custom module adds extra node operations that shouldn't have rabbit hole settings. If so, I might revisit this later and try a more complex solution - probably provide a whitelist of operations in an entity plugin method with some reasonable defaults if it's not overridden.
Comment #9
philliphg commented