Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
As it has been introduced in #1850080: Entity type labels lack plurality, cannot generate UI text based on label if plural is needed now we have a way to specify plural label for any entity type.
Proposed resolution
Add plural labels to all entity types defined in the module. More information can be found in the change record: https://www.drupal.org/node/2689949
See the core issue for an example: #2702683: Add plural labels to entity types.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | elastic_email-plural-6.patch | 905 bytes | mike.davis |
| elastic_email-plural.patch | 737 bytes | pashupathi nath gajawada |
Comments
Comment #2
mike.davis CreditAttribution: mike.davis at Deeson commentedThis doesn't seem to break anything and works fine, so RTBC this to get committed
Comment #4
mike.davis CreditAttribution: mike.davis at Deeson commentedThis has been committed now, thanks
Comment #6
mike.davis CreditAttribution: mike.davis at Deeson commentedI have reopening this as I have just noticed that this is causing a fatal warning when sending an email:
[Syntax Error] Expected Doctrine\Common\Annotations\DocLexer::T_CLOSE_PARENTHESIS, got 'label_plural' at position 154 in class Drupal\elastic_email\Plugin\Mail\ElasticEmailMailSystemThe attached patch fixes this.
Comment #7
mike.davis CreditAttribution: mike.davis at Deeson commentedupdated status
Comment #9
mike.davis CreditAttribution: mike.davis at Deeson commentedThis updated patch has been applied now