Share this does not work when change content layout, for example, two column layout.

CommentFileSizeAuthor
#7 share_this_does_not-2728639-7.patch1.18 KBnavneet0693
#2 share_this_does_not-2728639-2.patch710 bytesheddn
#5 interdiff.txt971 bytesnavneet0693
#5 share_this_does_not-2728639-5.patch1.52 KBnavneet0693

Comments

cacrody created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
StatusFileSize
new share_this_does_not-2728639-2.patch710 bytes

The implementation in hook_ENTITY_TYPE_view for the psuedo field doesn't match the name in hook_entity_extra_field_info

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Priority: Major » Normal
Status: Needs review » Needs work

Then there should also be the problem in sharethis_comment_view that also needs updation, we can take care of that here as well

navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review
StatusFileSize
new share_this_does_not-2728639-5.patch1.52 KB
new interdiff.txt971 bytes
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Needs work 
+++ b/sharethis.module
@@ -198,7 +198,7 @@ function sharethis_comment_view(array &$build, EntityInterface $comment, EntityV
+      '#attributes' => array('class' => 'sharethis'),

Why this change ?

navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review
StatusFileSize
new share_this_does_not-2728639-7.patch1.18 KB

Rolling back unwanted changes.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Component: Miscellaneous » Code
Status: Needs review » Reviewed & tested by the community

looks good

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2655010: Sharethis - 8.x-2.0-beta3

Thanks

  • naveenvalecha committed 33f3c5c on 8.x-2.x authored by heddn 
    Issue #2728639 by navneet0693, heddn, naveenvalecha: Share this does not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.