Problem/Motivation

If some rows have error (like not having the geofield information), no marker appears on the map.

Warning : array_merge(): Argument #1 is not an array dans Drupal\leaflet_views\Plugin\views\style\MarkerDefault->renderGroupingSets()

Proposed resolution

Check if the row is not false, if it is just ignore it (unset)

Remaining tasks

Test the patch and commit.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 no_markers_are_rendered-2713085-3.patch669 bytesharings_rob
#2 no_markers_are_rendered-2713085-2.patch679 bytesmorsok

Comments

morsok created an issue. See original summary.

morsok’s picture

morsok
Primary language French
Location Paris
commented
Status: Active » Needs review
StatusFileSize
new no_markers_are_rendered-2713085-2.patch679 bytes

Here's a patch.

harings_rob’s picture

harings_rob commented
StatusFileSize
new no_markers_are_rendered-2713085-3.patch669 bytes

Hmm, I had something similar, but in my case I would get a fatal error.

Attached patch resolves that issue, might be related.

harings_rob’s picture

harings_rob commented

In fact, I needed both patches for everything to work. Maybe I just need #3 because of misconfiguration?

  • pvhee committed 01167fe on 8.x-1.x authored by morsok 
    Issue #2713085 by morsok: No markers are rendered if some rows have...
pvhee’s picture

pvhee commented
Status: Needs review » Fixed

Harings_rob, your patch is similar to the commit that went in: http://cgit.drupalcode.org/leaflet/commit/?id=7869326

Committed patch #2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.