Problem/Motivation

Field instance settings for custom User fields are not migrating, e.g. custom fields are hidden editing a user (after migration).

Proposed resolution

Currently the query to obtain field instance settings is restricted to nodes - removing this condition will resolve the problem.

Remaining tasks

Remove condition on migration of field instance settings.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#24 d7_user_field_instance_settings_not_migrating-2675470-24.patch17.57 KBjofitz
#22 d7_user_field_instance_settings_not_migrating-2675470-22.patch17.57 KBjofitz
#22 interdiff.txt471 bytesjofitz
#20 d7_user_field_instance_settings_not_migrating-2675470-20.patch17.57 KBjofitz
#18 d7_user_field_instance_settings_not_migrating-2675470-18.patch17.21 KBhussainweb
#16 sshot-field-instance-after.png4.49 KBhussainweb
#16 sshot-field-instance-0.png2.88 KBhussainweb
#15 d7_user_field_instance_settings_not_migrating-2675470-15.patch17.2 KBjofitz
#15 interdiff.txt2.52 KBjofitz
#13 d7_user_field_instance_settings_not_migrating-2675470-13.patch14.67 KBjofitz
#13 interdiff.txt1.58 KBjofitz
#9 d7_user_field_instance_settings_not_migrating-2675470-9-complete.patch13.1 KBjofitz
#9 d7_user_field_instance_settings_not_migrating-2675470-9-tests.patch12.47 KBjofitz
#2 d7_user_field_instance_settings_not_migrating-2675470-2.patch644 bytesjofitz

Comments

Jo Fitzgerald created an issue. See original summary.

jofitz’s picture

jofitz
he/him
commented
Status: Active » Needs review
StatusFileSize
new d7_user_field_instance_settings_not_migrating-2675470-2.patch644 bytes

Remove condition on migration of field instance settings.

quietone’s picture

quietone commented
Issue tags: +migrate-d7-d8
benjy’s picture

benjy commented
Issue tags: +Needs tests

Seems reasonable, just needs some tests.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jofitz’s picture

jofitz
he/him
commented
Version: 8.1.x-dev » 8.1.1

Checking in v8.1.1

jofitz’s picture

jofitz
he/him
commented
Version: 8.1.1 » 8.1.x-dev

Version changed in error.

jmuzz’s picture

jmuzz commented
Title: D7 User field instance settings not migrating » D7 field instance settings for any fields not on nodes are not migrating

This also affects fields on taxonomy terms and any other entities that aren't nodes such as ECK entities, field collection items, etc.

jofitz’s picture

jofitz
he/him
commented
StatusFileSize
new d7_user_field_instance_settings_not_migrating-2675470-9-tests.patch12.47 KB
new d7_user_field_instance_settings_not_migrating-2675470-9-complete.patch13.1 KB

Added tests for:
* Users
* Comments
* Taxonomy terms

jofitz’s picture

jofitz
he/him
commented
Issue tags: -Needs tests

The last submitted patch, 9: d7_user_field_instance_settings_not_migrating-2675470-9-tests.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: d7_user_field_instance_settings_not_migrating-2675470-9-complete.patch, failed testing.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.58 KB
new d7_user_field_instance_settings_not_migrating-2675470-13.patch14.67 KB

Correct patch failures:
* Update expected entity counts
* Migrate (newly required) taxonomy vocabulary in Node test.

Status: Needs review » Needs work

The last submitted patch, 13: d7_user_field_instance_settings_not_migrating-2675470-13.patch, failed testing.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.52 KB
new d7_user_field_instance_settings_not_migrating-2675470-15.patch17.2 KB

Correct patch failures.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new sshot-field-instance-0.png2.88 KB
new sshot-field-instance-after.png4.49 KB

I tested this and it works great. The patch looks correct as well and except for tests that seem to be repeated in various other patches in the queue, everything looks good.

Before:
Before

After:
After

As for the repeated tests, we would have to reroll other patches once this gets in. It also makes logical sense to commit this one first as this one is about instances.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 15: d7_user_field_instance_settings_not_migrating-2675470-15.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new d7_user_field_instance_settings_not_migrating-2675470-18.patch17.21 KB

Rerolled and setting it back to RTBC as it is a simple reroll.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: d7_user_field_instance_settings_not_migrating-2675470-18.patch, failed testing.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new d7_user_field_instance_settings_not_migrating-2675470-20.patch17.57 KB

Rerolled and setting it back to RTBC as it is a simple reroll.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 20: d7_user_field_instance_settings_not_migrating-2675470-20.patch, failed testing.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new interdiff.txt471 bytes
new d7_user_field_instance_settings_not_migrating-2675470-22.patch17.57 KB

Correct id error in test fixtures.

Functionality still has not changed since #15 so setting back to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 22: d7_user_field_instance_settings_not_migrating-2675470-22.patch, failed testing.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new d7_user_field_instance_settings_not_migrating-2675470-24.patch17.57 KB

Re-rolled patch yet again due to conflict in MigrateUpgrade7Test.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 35a5e6bc433f4edd4341f79a33028beae9ae7c68 to 8.2.x and 3e77ea2 to 8.1.x. Thanks!

  • alexpott committed 35a5e6b on 8.2.x 
    Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

  • alexpott committed 3e77ea2 on 8.1.x 
    Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

  • alexpott committed 35a5e6b on 8.3.x 
    Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

  • alexpott committed 35a5e6b on 8.3.x 
    Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.