D7 field instance settings for any fields not on nodes are not migrating [#2675470]

Problem/Motivation

Field instance settings for custom User fields are not migrating, e.g. custom fields are hidden editing a user (after migration).

Proposed resolution

Currently the query to obtain field instance settings is restricted to nodes - removing this condition will resolve the problem.

Remaining tasks

Remove condition on migration of field instance settings.

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#24	d7_user_field_instance_settings_not_migrating-2675470-24.patch	17.57 KB	jofitz
#24	8.1.x: PHP 5.5 & MySQL 5.5 18,689 pass
#22	d7_user_field_instance_settings_not_migrating-2675470-22.patch	17.57 KB	jofitz
#22	8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply
#22	interdiff.txt	471 bytes	jofitz
#20	d7_user_field_instance_settings_not_migrating-2675470-20.patch	17.57 KB	jofitz
#20	8.1.x: PHP 5.5 & MySQL 5.5 18,629 pass, 180 fail
#18	d7_user_field_instance_settings_not_migrating-2675470-18.patch	17.21 KB	hussainweb
#18	8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply
#16	sshot-field-instance-after.png	4.49 KB	hussainweb
#16	sshot-field-instance-0.png	2.88 KB	hussainweb
#15	d7_user_field_instance_settings_not_migrating-2675470-15.patch	17.2 KB	jofitz
#15	8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply
#15	interdiff.txt	2.52 KB	jofitz
#13	d7_user_field_instance_settings_not_migrating-2675470-13.patch	14.67 KB	jofitz
#13	8.1.x: PHP 5.5 & MySQL 5.5 18,618 pass, 3 fail
#13	interdiff.txt	1.58 KB	jofitz
#9	d7_user_field_instance_settings_not_migrating-2675470-9-complete.patch	13.1 KB	jofitz
#9	8.1.x: PHP 5.5 & MySQL 5.5 18,612 pass, 7 fail
#9	d7_user_field_instance_settings_not_migrating-2675470-9-tests.patch	12.47 KB	jofitz
#9	8.1.x: PHP 5.5 & MySQL 5.5 18,611 pass, 8 fail
#2	d7_user_field_instance_settings_not_migrating-2675470-2.patch	644 bytes	jofitz
#2	8.0.x: PHP 5.5 & MySQL 5.5 14,573 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

25 February 2016 at 12:10

Jo Fitzgerald created an issue. See original summary.

Comment #2

jofitz CreditAttribution: jofitz commented 25 February 2016 at 12:13

Status:

Active

» Needs review

File	Size
d7_user_field_instance_settings_not_migrating-2675470-2.patch	644 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,573 pass

Remove condition on migration of field instance settings.

Comment #3

quietone CreditAttribution: quietone as a volunteer commented 3 March 2016 at 06:02

Issue tags:

+migrate-d7-d8

Comment #4

benjy CreditAttribution: benjy at PreviousNext commented 12 March 2016 at 03:20

Issue tags:

+Needs tests

Seems reasonable, just needs some tests.

Comment #5

12 March 2016 at 03:20

Version:

8.0.x-dev

» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #6

jofitz CreditAttribution: jofitz commented 23 May 2016 at 16:22

Version:

8.1.x-dev

» 8.1.1

Checking in v8.1.1

Comment #7

jofitz CreditAttribution: jofitz commented 24 May 2016 at 14:33

Version:

8.1.1

» 8.1.x-dev

Version changed in error.

Comment #8

jmuzz CreditAttribution: jmuzz commented 27 May 2016 at 19:00

Title:

D7 User field instance settings not migrating

» D7 field instance settings for any fields not on nodes are not migrating

This also affects fields on taxonomy terms and any other entities that aren't nodes such as ECK entities, field collection items, etc.

Comment #9

jofitz CreditAttribution: jofitz at ComputerMinds commented 24 June 2016 at 09:46

File	Size
d7_user_field_instance_settings_not_migrating-2675470-9-tests.patch	12.47 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,611 pass, 8 fail
d7_user_field_instance_settings_not_migrating-2675470-9-complete.patch	13.1 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,612 pass, 7 fail

1 file was hidden/shown/deleted

File	Size
d7_user_field_instance_settings_not_migrating-2675470-2.patch	644 bytes
8.0.x: PHP 5.5 & MySQL 5.5 14,573 pass

Added tests for:
* Users
* Comments
* Taxonomy terms

Comment #10

jofitz CreditAttribution: jofitz at ComputerMinds commented 24 June 2016 at 09:48

Issue tags:

-Needs tests

Comment #11

24 June 2016 at 10:26

The last submitted patch, 9: d7_user_field_instance_settings_not_migrating-2675470-9-tests.patch, failed testing.

Comment #12

24 June 2016 at 10:31

Status:

Needs review

» Needs work

The last submitted patch, 9: d7_user_field_instance_settings_not_migrating-2675470-9-complete.patch, failed testing.

Comment #13

jofitz CreditAttribution: jofitz at ComputerMinds commented 24 June 2016 at 12:08

Status:

Needs work

» Needs review

File	Size
interdiff.txt	1.58 KB
d7_user_field_instance_settings_not_migrating-2675470-13.patch	14.67 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,618 pass, 3 fail

2 files were hidden/shown/deleted

File	Size
d7_user_field_instance_settings_not_migrating-2675470-9-tests.patch	12.47 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,611 pass, 8 fail
d7_user_field_instance_settings_not_migrating-2675470-9-complete.patch	13.1 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,612 pass, 7 fail

Correct patch failures:
* Update expected entity counts
* Migrate (newly required) taxonomy vocabulary in Node test.

Comment #14

24 June 2016 at 13:01

Status:

Needs review

» Needs work

The last submitted patch, 13: d7_user_field_instance_settings_not_migrating-2675470-13.patch, failed testing.

Comment #15

jofitz CreditAttribution: jofitz at ComputerMinds commented 24 June 2016 at 13:57

Status:

Needs work

» Needs review

File	Size
interdiff.txt	2.52 KB
d7_user_field_instance_settings_not_migrating-2675470-15.patch	17.2 KB
8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply

2 files were hidden/shown/deleted

File	Size
interdiff.txt	1.58 KB
d7_user_field_instance_settings_not_migrating-2675470-13.patch	14.67 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,618 pass, 3 fail

Correct patch failures.

Comment #16

hussainweb

English

CreditAttribution: hussainweb at Axelerant commented 10 July 2016 at 09:36

Status:

Needs review

» Reviewed & tested by the community

File	Size
sshot-field-instance-0.png	2.88 KB
sshot-field-instance-after.png	4.49 KB

I tested this and it works great. The patch looks correct as well and except for tests that seem to be repeated in various other patches in the queue, everything looks good.

Before:
Before

After:
After

As for the repeated tests, we would have to reroll other patches once this gets in. It also makes logical sense to commit this one first as this one is about instances.

Comment #17

15 July 2016 at 14:29

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 15: d7_user_field_instance_settings_not_migrating-2675470-15.patch, failed testing.

Comment #18

hussainweb

English

CreditAttribution: hussainweb at Axelerant commented 15 July 2016 at 15:09

Status:

Needs work

» Reviewed & tested by the community

File	Size
d7_user_field_instance_settings_not_migrating-2675470-18.patch	17.21 KB
8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply

Rerolled and setting it back to RTBC as it is a simple reroll.

Comment #19

20 July 2016 at 08:53

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 18: d7_user_field_instance_settings_not_migrating-2675470-18.patch, failed testing.

Comment #20

jofitz CreditAttribution: jofitz at ComputerMinds commented 20 July 2016 at 09:45

Status:

Needs work

» Reviewed & tested by the community

File	Size
d7_user_field_instance_settings_not_migrating-2675470-20.patch	17.57 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,629 pass, 180 fail

5 files were hidden/shown/deleted

File	Size
interdiff.txt	2.52 KB
d7_user_field_instance_settings_not_migrating-2675470-15.patch	17.2 KB
8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply
sshot-field-instance-0.png	2.88 KB
sshot-field-instance-after.png	4.49 KB
d7_user_field_instance_settings_not_migrating-2675470-18.patch	17.21 KB
8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply

Rerolled and setting it back to RTBC as it is a simple reroll.

Comment #21

20 July 2016 at 10:35

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 20: d7_user_field_instance_settings_not_migrating-2675470-20.patch, failed testing.

Comment #22

jofitz CreditAttribution: jofitz at ComputerMinds commented 20 July 2016 at 11:09

Status:

Needs work

» Reviewed & tested by the community

File	Size
interdiff.txt	471 bytes
d7_user_field_instance_settings_not_migrating-2675470-22.patch	17.57 KB
8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply

1 file was hidden/shown/deleted

File	Size
d7_user_field_instance_settings_not_migrating-2675470-20.patch	17.57 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,629 pass, 180 fail

Correct id error in test fixtures.

Functionality still has not changed since #15 so setting back to RTBC.

Comment #23

20 July 2016 at 11:23

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 22: d7_user_field_instance_settings_not_migrating-2675470-22.patch, failed testing.

Comment #24

jofitz CreditAttribution: jofitz at ComputerMinds commented 20 July 2016 at 11:44

Status:

Needs work

» Reviewed & tested by the community

File	Size
d7_user_field_instance_settings_not_migrating-2675470-24.patch	17.57 KB
8.1.x: PHP 5.5 & MySQL 5.5 18,689 pass

2 files were hidden/shown/deleted

File	Size
interdiff.txt	471 bytes
d7_user_field_instance_settings_not_migrating-2675470-22.patch	17.57 KB
8.1.x: PHP 5.5 & MySQL 5.5 Patch failed to apply

Re-rolled patch yet again due to conflict in MigrateUpgrade7Test.

Comment #25

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 20 July 2016 at 23:18

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed 35a5e6bc433f4edd4341f79a33028beae9ae7c68 to 8.2.x and 3e77ea2 to 8.1.x. Thanks!

Comment #26

21 July 2016 at 00:34

alexpott committed 35a5e6b on 8.2.x

Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

Comment #27

21 July 2016 at 08:09

alexpott committed 3e77ea2 on 8.1.x

Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

Comment #28

3 August 2016 at 00:04

alexpott committed 35a5e6b on 8.3.x

Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

Comment #29

3 August 2016 at 00:05

alexpott committed 35a5e6b on 8.3.x

Issue #2675470 by Jo Fitzgerald, hussainweb: D7 field instance settings...

Comment #30

17 August 2016 at 00:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

D7 field instance settings for any fields not on nodes are not migrating

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Referenced by