Using the command dialog_redirect_command causes JS error ReferenceError: data is not defined in ajax.js (Line: 622)

I added a patch, it's my first one not sure if it's correct.

CommentFileSizeAuthor
#6 dialog-ajax-redirect-2660264-6.patch382 byteskarlshea
ajax.patch297 bytesgurksor

Comments

gurksor created an issue. See original summary.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Active » Reviewed & tested by the community

Worked for me!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, ajax.patch, failed testing.

devin carlson’s picture

devin carlson commented
Version: 7.x-2.0-alpha8 » 7.x-2.x-dev
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, ajax.patch, failed testing.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new dialog-ajax-redirect-2660264-6.patch382 bytes
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

gurksor should get commit credit, not me.

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch! Tested and committed to Dialog 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.