Remove depreciated methods and unused imports in code base.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2656162-9.patch | 4.91 KB | heykarthikwithu |
| #5 | interdiff-2656162-2-5.txt | 5.04 KB | heykarthikwithu |
| #5 | 2656162-5.patch | 7.71 KB | heykarthikwithu |
| #2 | 2656162-2.patch | 4.12 KB | heykarthikwithu |
Comments
Comment #2
heykarthikwithuComment #3
nedjoThanks for the patch.
Suggestions:
Comment #4
heykarthikwithuworking on this.
Comment #5
heykarthikwithuAs per #3, suggestions are updated.
Comment #6
jhodgdonThat looks good, thanks! I think it may conflict with some similar work done as part of #2659178: Add delete capability, so I think I'll wait to commit this for a bit.
Comment #7
jhodgdonSorry, I forgot about this... and indeed it doesn't apply any more.
Comment #8
heykarthikwithuworking on this.
Comment #9
heykarthikwithurerolled.
Comment #11
jhodgdonThanks! I can definitely apply this patch... but:
I thought in the last version of this patch, besides using EntityTypeManagerInterface, it also changed the local/member variable names to $entity_type_manager? That seemed like a good idea.
Here too.
Although I guess that changing even protected member variable names is probably not a good idea... so OK, let's leave the variable names as-is. I'll just commit this. Thanks again!
Comment #12
heykarthikwithu@jhodgdon yes, local variable name can also be $entity_type_manager .
okay, thanks.