Closed (fixed)
Project:
Crazy Egg Integration
Version:
8.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jan 2016 at 11:50 UTC
Updated:
15 Feb 2016 at 03:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
heykarthikwithu1. replaced the deprecated usage of \Drupal::l with Link::fromTextAndUrl.
Comment #3
michelleThanks for this. Is the module otherwise working for you? I don't personally use it. I ported it for a work client and haven't gotten much outside feedback. If it's working for people, I'll get this cleaned up and get a new release out sometime this week.
Comment #4
heykarthikwithuwhat i added in the patch was a replace for a deprecated usage. i did not enable this module, since their was no need to test the code after applying this minor change.
Comment #5
michelleOh, you aren't using it? Just a drive by patching? ;) Setting this back to needs review because I haven't gotten to it, yet. Not sure if it will be this week. I ended up with a task that sucked up all my internal time so it might be next week.
Comment #7
michelleCommitted, thanks!
Comment #8
michelle"since their was no need to test the code after applying this minor change."
Wow... I actually fell for that. LOL! My bad for just committing this untested. I'll give myself 50 lashes with a wet noodle. ;)
As a matter of fact, there _is_ a need to test this as it causes a fatal error. I'm in the process of figuring out how to fix it.
Comment #9
michelleWe were making this waaaay too complicated. Fixed it. Patch attached for reference but marking fixed because I'm going to go ahead and commit it.